[7.0.0] "I/O exception during sandboxed execution" "Directory not empty" with --experimental_reuse_sandbox_directories
#19959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bazelbuild#19935 gives a clear repro. The problem appears when a stashed sandbox contains a directory whose same path is a regular file in a later execution. If we try to reuse the stashed sandbox we trigger an error if the old directory contained any files. This was due to simply calling delete() without checking first if it was a directory. The fix is to call deleteTree() instead in those cases. directory. Fixes bazelbuild#19935 RELNOTES:none PiperOrigin-RevId: 576889004 Change-Id: I73b145cd574b83c473ffaccd90b675eb5f086c0e
bazel-io
added
team-Local-Exec
oquenchil
approved these changes
Oct 30, 2023
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19935 gives a clear repro. The problem appears when a stashed sandbox
contains a directory whose same path is a regular file in a later
execution. If we try to reuse the stashed sandbox we trigger an error if
the old directory contained any files.
This was due to simply calling delete() without checking first if it
was a directory. The fix is to call deleteTree() instead in those cases.
directory.
Fixes #19935
RELNOTES:none
Commit 7d87996
PiperOrigin-RevId: 576889004
Change-Id: I73b145cd574b83c473ffaccd90b675eb5f086c0e