-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/3] Bump grpc from 1.47.0 to 1.48.1 #18240
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Apr 27, 2023
sgowroji
added
the
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
label
Apr 28, 2023
PART 1: prepare third_party/grpc files for new version Composed PR: bazelbuild#18216. Fixes bazelbuild#18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92
davido
force-pushed
the
grpc_1_48_1_part_1
branch
from
April 28, 2023 05:11
2c91fa7
to
465748a
Compare
meteorcloudy
approved these changes
Apr 28, 2023
meteorcloudy
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Apr 28, 2023
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
PART 1: prepare third_party/grpc files for new version Composed PR: #18216. Fixes #18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92 Partial commit for third_party/*, see #18240. Signed-off-by: Pavan Singh <[email protected]>
Merged at d18c506 |
sgowroji
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Apr 28, 2023
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
PART 1: prepare third_party/grpc files for new version Composed PR: bazelbuild#18216. Fixes bazelbuild#18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92 Partial commit for third_party/*, see bazelbuild#18240. Signed-off-by: Pavan Singh <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Previous PR: bazelbuild#18240 Closes bazelbuild#18241. PiperOrigin-RevId: 528053742 Change-Id: I360b0b1db6ff22464939bfa388b185c980dd4ec4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PART 1: prepare third_party/grpc files for new version
Composed PR: #18216.
Fixes #18167.
abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1].
Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible.
[1] abseil/abseil-cpp@36a4b07
[2] abseil/abseil-cpp@b8bbe92