Bump grpc to 1.48.1 and abseil-cpp to 20220623.1 #18216
Closed
+113
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
|
Is the test breakage on Darwin is actually unrelated here? Now we are missing only blzmod for grpc 1.48.1? |
sgowroji
added
team-OSS
|
@davido Yes, we are doing some tuning for Bazel CI which caused some test timeouts, sorry about that! |
Yes, unfortunately the grpc team doesn't maintain the BCR module currently, do you mind giving it a try to update it? |
Can you restart the verification once the problem fixed?
You mean to upload a new BCR module version for grpc: 1.48.1? Yes, will do. |
|
Once this PR is merged, should I bump grpc blzmod version to 1.48.1 in this PR as well? We are also missing bazel mirror for grpc 1.48.1 tarball: Requested the mirror for grpc 1.48.1 here. |
This was referenced Apr 27, 2023
Fixes bazelbuild#18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92
davido
force-pushed
the
bump_grpc_version
branch
from
718e84b to
5684ce2
Compare
Yes, please do! |
Done. |
Also bump version of bazel_skylib to 1.4.1, because transitive dependency of grpc: abseil-cpp was updated to 20220623.1, that requires new vrsion of bazel_skylib.
davido
force-pushed
the
bump_grpc_version
branch
from
39b2d3e to
7c0c200
Compare
|
We'll have to merge the changes in the third_party change separately, can you split this change into three ones:
|
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 27, 2023
PART 1: prepare third_party/grpc files for new version Composed PR: bazelbuild#18216. Fixes bazelbuild#18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 27, 2023
PART 2: switch to v1.48.1 Composed PR: bazelbuild#18216.
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 27, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: bazelbuild#18216.
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
PART 1: prepare third_party/grpc files for new version Composed PR: bazelbuild#18216. Fixes bazelbuild#18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
PART 2: switch to v1.48.1 Composed PR: bazelbuild#18216.
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: bazelbuild#18216.
|
@davido Thanks! |
|
@meteorcloudy thank you for your assistance and fast review, very much appreciated! |
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
PART 1: prepare third_party/grpc files for new version Composed PR: #18216. Fixes #18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92 Partial commit for third_party/*, see #18240. Signed-off-by: Pavan Singh <[email protected]>
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
PART 2: switch to v1.48.1 Composed PR: bazelbuild#18216.
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: bazelbuild#18216.
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: bazelbuild#18216.
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
PART 2: switch to v1.48.1 Composed PR: bazelbuild#18216.
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 28, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: bazelbuild#18216.
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 29, 2023
PART 2: switch to v1.48.1 Composed PR: #18216. Partial commit for third_party/*, see #18241. Signed-off-by: Pavan Singh <[email protected]>
davido
added a commit
to davido/bazel
that referenced
this pull request
Apr 29, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: bazelbuild#18216.
copybara-service bot
pushed a commit
that referenced
this pull request
May 2, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: #18216. Partial commit for third_party/*, see #18242. Signed-off-by: Pavan Singh <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
PART 1: prepare third_party/grpc files for new version Composed PR: bazelbuild#18216. Fixes bazelbuild#18167. abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1]. Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible. [1] abseil/abseil-cpp@36a4b07 [2] abseil/abseil-cpp@b8bbe92 Partial commit for third_party/*, see bazelbuild#18240. Signed-off-by: Pavan Singh <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
PART 2: switch to v1.48.1 Composed PR: bazelbuild#18216. Partial commit for third_party/*, see bazelbuild#18241. Signed-off-by: Pavan Singh <[email protected]>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Part 3: remove 1.47.0 from third_party/grpc Composed PR: bazelbuild#18216. Partial commit for third_party/*, see bazelbuild#18242. Signed-off-by: Pavan Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18167.
abseil-cpp is missing stdint.h header include, that broke recent compiler versions. This problem was fixed in this commit upstream: [1].
Due to another commit: [2] in abseil-cpp, we also have to bump grpc as well to make them compatible.
[1] abseil/abseil-cpp@36a4b07
[2] abseil/abseil-cpp@b8bbe92