Fix --nozip_undeclared_test_outputs on Windows
#16973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
fix-nozip-undeclared-test-outputs-on-windows
branch
5 times, most recently
from
5b0af74
to
fd6897b
Compare
Without this change, testing with `--nozip_undeclared_test_outputs` always fails with this error: ``` FATAL: MappedOutputFile(): CreateFileW() failed: (error: 3): The system cannot find the path specified. ```
fmeum
force-pushed
the
fix-nozip-undeclared-test-outputs-on-windows
branch
from
fd6897b
to
ccd8f48
Compare
fmeum
commented
Dec 9, 2022
| ], ) | ||
| self.AssertExitCode(exit_code, 0, stderr) | ||
| # FIXME: The Windows test runner does not delete the undeclared outputs | ||
| # after zipping, which differs from the behavior on other platforms. |
There was a problem hiding this comment.
Fixing this would require implementing recursive directory removal in the Windows runner. The code already exists in src/main/cpp/util/file_windows.cc, let me know if you want me to copy it over.
There was a problem hiding this comment.
I'm okay with fixing this separately.
sgowroji
added
team-Remote-Exec
tjgq
approved these changes
Dec 12, 2022
| ], ) | ||
| self.AssertExitCode(exit_code, 0, stderr) | ||
| # FIXME: The Windows test runner does not delete the undeclared outputs | ||
| # after zipping, which differs from the behavior on other platforms. |
There was a problem hiding this comment.
I'm okay with fixing this separately.
tjgq
added
awaiting-PR-merge
|
@bazel-io flag |
|
(flagging for 6.1.0, not a regression) |
bazel-io
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 25, 2023
Without this change, testing with `--nozip_undeclared_test_outputs` always fails with this error: ``` FATAL: MappedOutputFile(): CreateFileW() failed: (error: 3): The system cannot find the path specified. ``` Closes #16973. PiperOrigin-RevId: 494953454 Change-Id: I8338e897a9e4f4fdcd6dad511ee8e777182fefcd Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, testing with
--nozip_undeclared_test_outputsalways fails with this error: