Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify building and testing #548

Merged
merged 4 commits into from
Dec 12, 2022
Merged

Simplify building and testing #548

merged 4 commits into from
Dec 12, 2022

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Dec 9, 2022

No description provided.

`-fsanitize=safe-stack` isn't enabled by default, so we don't have to
explicitly disable it.
@fmeum fmeum marked this pull request as ready for review December 9, 2022 14:23
@fmeum fmeum mentioned this pull request Dec 9, 2022
Forgetting to set `JAZZER_CI=1` locally frequently resulted in tests
failing in CI that passed locally.

With the JUnit integration, we will rely less and less on having users
run examples via Bazel. Running them with the full checks isn't all that
different from running without anyway, with no noticeable output lag.
@fmeum fmeum force-pushed the FUZZ-460-improve-dev-experience branch from 56f8e68 to be715f4 Compare December 9, 2022 14:59
@fmeum
Copy link
Contributor Author

fmeum commented Dec 9, 2022

I created bazelbuild/bazel#16973 to fix the Bazel bug and added a workaround for the meantime: Windows users will not be able to access the files emitted by our examples unless they figure out that there is a zip file containing them in the same directory. Do you think that's fine for now? Bazel on Windows doesn't delete undeclared outputs after zipping them, so this works on all OSes.

These tests frequently timeout on macOS runner before reaching the runs
limit.
@fmeum fmeum changed the title Dev experience improvements Simplify building and testing Dec 9, 2022
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fmeum fmeum merged commit ebc4d19 into main Dec 12, 2022
@fmeum fmeum deleted the FUZZ-460-improve-dev-experience branch December 12, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants