Remove use of -undefined dynamic_lookup on darwin #16414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag ignores undefined symbols at link time and forces them to be looked up dynamically. This is incompatible with the newer fixup chains macho format and theoretically shouldn't be necessary assuming your dependencies are well defined. Fixes bazelbuild#16413
keith
force-pushed
the
ks/remove-use-of-undefined-dynamic_lookup-on-darwin
branch
from
65bc2a9
to
f0b850f
Compare
|
The second commit here shows a potential issue making this change could introduce, that library had incorrect dependencies but just happened to work at runtime because the library it needed must have been transitively loaded anyways. I also found this #7607 |
sgowroji
added
team-Rules-CPP
|
@oquenchil can you take a look? |
oquenchil
approved these changes
Jan 9, 2023
oquenchil
added
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
for future reference there were some previous additions / removals of this too: #67 |
|
This looks like a breaking change: Detected by culprit finder: https://buildkite.com/bazel/culprit-finder/builds/4178#0185a952-34c1-46ae-99c8-9b40d67508ec |
|
Since this is likely a breaking change, I'll remove the "potential release blocker" label. |
meteorcloudy
removed
the
potential release blocker
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
This flag ignores undefined symbols at link time and forces them to be looked up dynamically. This is incompatible with the newer fixup chains macho format and theoretically shouldn't be necessary assuming your dependencies are well defined. Fixes #16413 Closes #16414. PiperOrigin-RevId: 501275674 Change-Id: I9240b2596ffea329ef55d3ad15e98635ba8839b6
keith
added a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
Feb 14, 2023
This flag ignores undefined symbols at link time and forces them to be looked up dynamically. This is incompatible with the newer fixup chains macho format and theoretically shouldn't be necessary assuming your dependencies are well defined. Done in bazel's toolchain here bazelbuild/bazel#16414
|
@keith Is googletest doing something wrong? git clone [email protected]:google/googletest.git
cd googletestBefore this change: USE_BAZEL_VERSION=7.0.0-pre.20221212.2 bazelisk test --java_runtime_version=remotejdk_11 --copt='-std=c++14' //googletest/test:gtest_all_testSucceeds After this change: USE_BAZEL_VERSION=7.0.0-pre.20230118.2 bazelisk test --java_runtime_version=remotejdk_11 --copt='-std=c++14' //googletest/test:gtest_all_test
ERROR: /Users/garymm/src/google/googletest/BUILD.bazel:152:11: Linking libgtest_main.dylib failed: (Exit 1): cc_wrapper.sh failed: error executing command (from target //:gtest_main) external/local_config_cc/cc_wrapper.sh @bazel-out/darwin_arm64-fastbuild/bin/libgtest_main.dylib-2.params
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
Undefined symbols for architecture arm64:
"testing::InitGoogleMock(int*, char**)", referenced from:
_main in gmock_main.pic.o
"testing::UnitTest::GetInstance()", referenced from:
RUN_ALL_TESTS() in gmock_main.pic.o
"testing::UnitTest::Run()", referenced from:
RUN_ALL_TESTS() in gmock_main.pic.o
ld: symbol(s) not found for architecture arm64 |
keith
added a commit
to keith/bazel
that referenced
this pull request
Feb 28, 2023
This feature isn't supported on macOS, and it isn't part of the Xcode CC toolchain, but it is left over here from when it was supported in the past. bazelbuild@ec55533 Fixes: bazelbuild#16414 (comment)
keith
added a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
Jul 17, 2023
This flag ignores undefined symbols at link time and forces them to be looked up dynamically. This is incompatible with the newer fixup chains macho format and theoretically shouldn't be necessary assuming your dependencies are well defined. Done in bazel's toolchain here bazelbuild/bazel#16414
keith
added a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
Jul 17, 2023
This flag ignores undefined symbols at link time and forces them to be looked up dynamically. This is incompatible with the newer fixup chains macho format and theoretically shouldn't be necessary assuming your dependencies are well defined. Done in bazel's toolchain here bazelbuild/bazel#16414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag ignores undefined symbols at link time and forces them to be looked up dynamically. This is incompatible with the newer fixup chains macho format and theoretically shouldn't be necessary assuming your dependencies are well defined.
Fixes #16413