Make filetypes case insensitive on Windows #14005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is aimed to solve issues like #13879 (comment) Is it better to add the case insensitivity case-by-case (or even casing case-by-case) rather than going for a general approach? |
oquenchil
added
area-Windows
torgil
force-pushed
the
case-insensitive-windows-filetypes
branch
from
4bfa043
to
a7f9d6c
Compare
Filetypes are based on checking file-extensions which are case insensitive on Windows. For example, A lib file could be named .lib, Lib, etc which is currently not allowed in for example cc_import. This patch allows file extensions to vary in case on Windows.
torgil
force-pushed
the
case-insensitive-windows-filetypes
branch
from
a7f9d6c
to
d1f92e4
Compare
torgil
commented
Oct 18, 2021
| @@ -96,7 +98,7 @@ public boolean apply(String path) { | |||
|
|
|||
| @Override | |||
| public boolean apply(String path) { | |||
| return (path.endsWith(ext) && !PIC_ASSEMBLER.matches(path)) || path.endsWith(".asm"); | |||
| return (OS.endsWith(path, ext) && !PIC_ASSEMBLER.matches(path)) || OS.endsWith(path, ".asm"); | |||
There was a problem hiding this comment.
This could make .S files end up with ASSEMBLE action instead of PREPROCESS_ASSEMBLE on Windows?
src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionBuilder.java:
} else if (CppFileTypes.ASSEMBLER.matches(sourcePath)) {
return CppActionNames.ASSEMBLE;
} else if (CppFileTypes.ASSEMBLER_WITH_C_PREPROCESSOR.matches(sourcePath)) {
return CppActionNames.PREPROCESS_ASSEMBLE;
There was a problem hiding this comment.
Indeed, is this a serious problem? Do you know how to distinguish assemble and preprocess assemble actions on Windows?
There was a problem hiding this comment.
@meteorcloudy we just saw that this is a problem also with .c and .C files, on one side Bazel considers .c as C and .C as C++, once you are case insensitive on Windows there is the problem that the .c files end up as C++ files.
There was a problem hiding this comment.
Yeah, looks like Make filetypes case insensitive is going to be an incompatible change, which may not have much gains for us. I think maybe the correctly way to is to make filetype configuration first? Just like the artifcat extension for binary/static library/dynamic library /cc @oquenchil
There was a problem hiding this comment.
For reference, this is the issue #15073
Gormo
pushed a commit
to Gormo/bazel
that referenced
this pull request
Oct 19, 2021
This fixes an issue introduced by PR bazelbuild#14005 where .s and .S extensions were handled case-insensitive on Windows so the action assemble was triggered instead of preprocess_assemble.
Gormo
pushed a commit
to Gormo/bazel
that referenced
this pull request
Nov 9, 2021
This fixes an issue introduced by PR bazelbuild#14005 where .s and .S extensions were handled case-insensitive on Windows so the action assemble was triggered instead of preprocess_assemble.
Gormo
pushed a commit
to Gormo/bazel
that referenced
this pull request
Nov 9, 2021
This fixes an issue introduced by PR bazelbuild#14005 where .s and .S extensions were handled case-insensitive on Windows so the action assemble was triggered instead of preprocess_assemble.
Bencodes
pushed a commit
to Bencodes/bazel
that referenced
this pull request
Jan 10, 2022
This fixes an issue introduced by PR bazelbuild#14005 where .s and .S extensions were handled case-insensitive on Windows so the action assemble was triggered instead of preprocess_assemble. Closes bazelbuild#14131. PiperOrigin-RevId: 412005097
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Jul 27, 2022
This fixes an issue introduced by PR bazelbuild#14005 where .s and .S extensions were handled case-insensitive on Windows so the action assemble was triggered instead of preprocess_assemble. Closes bazelbuild#14131. PiperOrigin-RevId: 412005097
sgowroji
pushed a commit
to sgowroji/bazel
that referenced
this pull request
Jul 27, 2022
This fixes an issue introduced by PR bazelbuild#14005 where .s and .S extensions were handled case-insensitive on Windows so the action assemble was triggered instead of preprocess_assemble. Closes bazelbuild#14131. PiperOrigin-RevId: 412005097
sgowroji
pushed a commit
that referenced
this pull request
Jul 27, 2022
This fixes an issue introduced by PR #14005 where .s and .S extensions were handled case-insensitive on Windows so the action assemble was triggered instead of preprocess_assemble. Closes #14131. PiperOrigin-RevId: 412005097 Co-authored-by: Simon Bjorklen <[email protected]>
kkpattern
added a commit
to kkpattern/bazel
that referenced
this pull request
Apr 17, 2023
This fixes an issue introduced by PR bazelbuild#14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes bazelbuild#15073 .
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This fixes an issue introduced by PR bazelbuild#14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes bazelbuild#15073 . Closes bazelbuild#18119. PiperOrigin-RevId: 526001251 Change-Id: I464e5feae397bdac443ddd159309f77071629e01
FaBrand
pushed a commit
to FaBrand/bazel
that referenced
this pull request
Jun 1, 2023
This fixes an issue introduced by PR bazelbuild#14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes bazelbuild#15073 . Closes bazelbuild#18119. PiperOrigin-RevId: 526001251 Change-Id: I464e5feae397bdac443ddd159309f77071629e01
iancha1992
pushed a commit
that referenced
this pull request
Jun 12, 2023
This fixes an issue introduced by PR #14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes #15073 . Closes #18119. PiperOrigin-RevId: 526001251 Change-Id: I464e5feae397bdac443ddd159309f77071629e01 Co-authored-by: Kai Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filetypes are based on checking file-extensions which are case insensitive on Windows.
For example, A lib file could be named .lib, Lib, etc which is currently not allowed
in for example cc_import.
This patch allows file extensions to vary in case on Windows.