Make cpp file extensions case sensitive again #18119
Closed
+44
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue introduced by PR bazelbuild#14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes bazelbuild#15073 .
github-actions
bot
added
the
awaiting-review
oquenchil
added
awaiting-PR-merge
Pavank1992
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This fixes an issue introduced by PR bazelbuild#14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes bazelbuild#15073 . Closes bazelbuild#18119. PiperOrigin-RevId: 526001251 Change-Id: I464e5feae397bdac443ddd159309f77071629e01
FaBrand
pushed a commit
to FaBrand/bazel
that referenced
this pull request
Jun 1, 2023
This fixes an issue introduced by PR bazelbuild#14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes bazelbuild#15073 . Closes bazelbuild#18119. PiperOrigin-RevId: 526001251 Change-Id: I464e5feae397bdac443ddd159309f77071629e01
iancha1992
pushed a commit
that referenced
this pull request
Jun 12, 2023
This fixes an issue introduced by PR #14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files. Closes #15073 . Closes #18119. PiperOrigin-RevId: 526001251 Change-Id: I464e5feae397bdac443ddd159309f77071629e01 Co-authored-by: Kai Zhang <[email protected]>
davidben
added a commit
to google/boringssl
that referenced
this pull request
Jul 5, 2023
This reverts commit 28e4a1b. Bazel broke --cxxopt on Windows in bazelbuild/bazel#15073, which means projects enabling, say, C++20 with --cxxopt=/std:c++20 are silently passing /std:c++20 to our C files. This is already a problem, but MSVC is smart enough to silently ignore the flag when building C. However, MSVC will report an error if you then pass /std:c++20 /std:c11 into the same command. It seems that check is not aware of this ignoring behavior. Ultimately, this is a Bazel bug, and one that makes the broken versions of Bazel unsuitable for use with C. This was fixed in Bazel in bazelbuild/bazel#18119 and backported to the upcoming Bazel 6.3.0 release in bazelbuild/bazel#18552 Temporarily revert the change. When Bazel 6.3.0 is released, we'll put this back and require Windows users use a functioning version of Bazel. Bug: 624 Fixed: 623 Change-Id: I68d9b2ed8751b4cf5dc7f42f8c1fbd42a97d6ca2 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/61365 Auto-Submit: David Benjamin <[email protected]> Commit-Queue: David Benjamin <[email protected]> Commit-Queue: Adam Langley <[email protected]> Reviewed-by: Adam Langley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced by PR #14005 where .c and .C extensions were handled case-insensitive on Windows so the cxxopt will be passed to C source files.
Closes #15073 .