Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - July 2018 - Target RC date: 2018-07-02 - name: 0.16.0 #5058

Closed
dslomov opened this issue Apr 19, 2018 · 40 comments
Closed

Release - July 2018 - Target RC date: 2018-07-02 - name: 0.16.0 #5058

dslomov opened this issue Apr 19, 2018 · 40 comments
Assignees
Labels

Comments

@dslomov
Copy link
Contributor

dslomov commented Apr 19, 2018

No description provided.

@dslomov
Copy link
Contributor Author

dslomov commented Apr 19, 2018

@c-parsons lmk if you are not available on these dates

@dslomov dslomov changed the title Release - July 2019 - Target RC date: 2018-07-02 - name: 0.16.0 Release - July 2018 - Target RC date: 2018-07-02 - name: 0.16.0 Apr 19, 2018
@buchgr buchgr assigned buchgr and unassigned c-parsons Jun 28, 2018
@c-parsons c-parsons assigned c-parsons and unassigned buchgr Jul 2, 2018
@c-parsons
Copy link
Contributor

@petemounce
Copy link
Contributor

Published to chocolatey.

@aehlig
Copy link
Contributor

aehlig commented Jul 3, 2018

Did we change something to the release process? I couldn't find the distribution archive at the expected https://storage.googleapis.com/bazel/0.16.0/rc1/bazel-0.16.0rc1-dist.zip nor anywhere else.

@Globegitter
Copy link

@c-parsons any deb packages or sh installers with that release?

@buchgr
Copy link
Contributor

buchgr commented Jul 3, 2018

Artifacts have been generated. There was a small delay due to CI issues, sorry about that. https://storage.googleapis.com/bazel/0.16.0/rc1/index.html

@buchgr
Copy link
Contributor

buchgr commented Jul 3, 2018

@c-parsons please cherry-pick 4c9a0c8

@c-parsons
Copy link
Contributor

rc2 has been cherrypicked with 4c9a0c8

@buchgr
Copy link
Contributor

buchgr commented Jul 5, 2018

@c-parsons please cherry-pick d3228b6

@hlopko
Copy link
Member

hlopko commented Jul 5, 2018

Pretty please cherry pick 8ff87c1 (fix for #5468)

@hlopko
Copy link
Member

hlopko commented Jul 6, 2018

And also c4622ac.

@aehlig
Copy link
Contributor

aehlig commented Jul 6, 2018 via email

@buchgr
Copy link
Contributor

buchgr commented Jul 9, 2018

Release blocker: #5532

@c-parsons
Copy link
Contributor

rc3 has been cherrypicked with: d3228b6, 8ff87c1, c4622ac, 1021965, ab1f269, 68e92b4

@ianoc
Copy link

ianoc commented Jul 12, 2018

#5572 is likely i think a release blocker too

@jin
Copy link
Member

jin commented Jul 22, 2018

#5648 may be a release blocker due to a bug with analyze-profile --html

@buchgr
Copy link
Contributor

buchgr commented Jul 23, 2018

Please cherry-pick 3842bd3

@buchgr
Copy link
Contributor

buchgr commented Jul 24, 2018

#5047 is a blocker. I ll have a fix by tomorrow.

@c-parsons
Copy link
Contributor

If I understand correctly, looks like #5572 was present in 0.15.0 so it's a non-blocker.

I am waiting on #5047 to be resolved before creating rc4.
For additional cherry-picks so far for rc4 we have:
f45c224 3842bd3

@buchgr
Copy link
Contributor

buchgr commented Jul 24, 2018

@c-parsons working late on a fix :-)

@ianoc-stripe
Copy link

#5572 wasn't present in 0.15.{0,1, 2} since thats what we run internally with distinct host configuration enabled. Though from the state there it looks like this isn't easily fixable, and has a somewhat workaround. So we might just want to note that in the release notes?

@buchgr
Copy link
Contributor

buchgr commented Jul 25, 2018

please cherry-pick bca1912 which fixed #5047

@c-parsons
Copy link
Contributor

rc4 is out.
new cherrypicks since rc3:
f45c224 3842bd3 bca1912
Announcement incoming.

@petemounce
Copy link
Contributor

rc4 is on chocolatey

@c-parsons
Copy link
Contributor

I have pushed release 0.16.0 and announced it. Blog post soon to follow.

@petemounce Could you please update chocolatey?
@ilovezfs Could you please update Homebrew?

(Thank you both very much!)

@buchgr
Copy link
Contributor

buchgr commented Jul 31, 2018

ping @vbatts

@vbatts
Copy link

vbatts commented Jul 31, 2018 via email

@schroederc
Copy link
Contributor

The release notes for 0.16.0 don't mention the update to the embedded JDK which is a breaking change. https://github.com/google/kythe is broken due to its usage of -Xbootclasspath/p to bring in the javac tools jar.

@buchgr
Copy link
Contributor

buchgr commented Jul 31, 2018

@schroederc sorry about that. Can you please file an issue with a more detailed error description?

@petemounce
Copy link
Contributor

Chocolatey is pushed.

@dslomov
Copy link
Contributor Author

dslomov commented Aug 6, 2018

@c-parsons ptal at OS X situation

@dslomov
Copy link
Contributor Author

dslomov commented Aug 6, 2018

Is #5730 a blocker, do we need a patch release?

@dslomov
Copy link
Contributor Author

dslomov commented Aug 6, 2018

Is #5741 a blocker?

@dslomov
Copy link
Contributor Author

dslomov commented Aug 6, 2018

(@c-parsons you are off the hook for OS X)

@c-parsons
Copy link
Contributor

What's the state of the OSX situation, then?

@c-parsons
Copy link
Contributor

Fix for #5683 should also be cherrypicked.

@dslomov
Copy link
Contributor Author

dslomov commented Aug 7, 2018

See #5777 (comment)

@buchgr
Copy link
Contributor

buchgr commented Aug 7, 2018

@c-parsons

we have decided that we need to rollback the JDK9 change and do a patch release that reverts the relevant changes. I have created a branch containing commits that need to be reverted and that seems to work: #5786

Can you take care of the patch release please?

UPDATE: Discussed the issue with @cushon and he has a patch #5760 that will allow Bazel's --javabase to work with JDK8 and JDK9. If this works out, our preference is to cherry pick this patch into 0.16.1 and not to the rollback to JDK8.

@c-parsons
Copy link
Contributor

Lets move further discussion to #5792, where I've summarized current status for patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests