Skip to content

0.16.0's analyze-profile --html output is exceedingly large #5648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jin opened this issue Jul 21, 2018 · 3 comments
Closed

0.16.0's analyze-profile --html output is exceedingly large #5648

jin opened this issue Jul 21, 2018 · 3 comments
Assignees

Comments

@jin
Copy link
Member

jin commented Jul 21, 2018

Description of the problem / feature request:

In 0.16.0rc1, the HTML profile generated from bazel analyze-profile --html is exceedingly large, containing timestamp <div> elements like the following:

<div style='position: absolute; left: 10505400px; top: -20px; width: 1px; height: 40px; border-left: 1px solid rgba(128,128,128,1.000000)'></div>
<div style="position:absolute; left:10505454px; top:-17px; width:50px; height:10px">210109s</div>
<div style='position: absolute; left: 10505450px; top: -20px; width: 1px; height: 40px; border-left: 1px solid rgba(128,128,128,1.000000)'></div>
<div style="position:absolute; left:10505504px; top:-17px; width:50px; height:10px">210110s</div>
<div style='position: absolute; left: 10505500px; top: -20px; width: 1px; height: 40px; border-left: 1px solid rgba(128,128,128,1.000000)'></div>

A HTML profile on //examples/cpp:hello-world is 48MB and has 420511 lines:

$ wc -l 0.16.0rc1.prof.html
  420511 0.16.0rc1.prof.html
$ ls -lh 0.16.0rc1.prof.html
-rw-r--r--  1 jingwen  5001    48M Jul 20 23:22 0.16.0rc1.prof.html

For comparison, the same profile generated from 0.15.2 is 279 lines:

$ wc -l 0.15.2.prof.html
     279 0.15.2.prof.html

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Build any target using Bazel 0.16.0 RC with --profile=prof.dat, and bazel analyze-profile --html prof.dat

What operating system are you running Bazel on?

macOS

What's the output of bazel info release?

0.16.0rc1

@jin
Copy link
Member Author

jin commented Jul 21, 2018

cc @meisterT @ulfjack could this be related to the recent profiler changes?

@jin jin changed the title bazel 0.16.0 analyze-profile --html output is exceedingly large 0.16.0's analyze-profile --html output is exceedingly large Jul 21, 2018
@jin
Copy link
Member Author

jin commented Jul 21, 2018

Bisected to 15b8c25

@ulfjack
Copy link
Contributor

ulfjack commented Jul 23, 2018

Fixed in f45c224. @lberki

@ulfjack ulfjack closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants