Skip to content

Quote docker cli path to support Windows paths with spaces #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smukherj1 merged 1 commit into from
May 22, 2020
Merged

Quote docker cli path to support Windows paths with spaces #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions rules/rbe_repo/extract.sh.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,19 @@ fi
%{copy_data_cmd}

# Pass an empty entrypoint to override any set by default in the container.
id=$(${DOCKER} run -d --entrypoint "" %{docker_run_flags} %{image_name} %{commands})
id=$("${DOCKER}" run -d --entrypoint "" %{docker_run_flags} %{image_name} %{commands})

${DOCKER} wait $id
"${DOCKER}" wait $id
# Check the docker logs contain the expected 'created outputs_tar' string
if ${DOCKER} logs $id | grep -q 'created outputs_tar'; then
if "${DOCKER}" logs $id | grep -q 'created outputs_tar'; then
echo "Successfully created outputs_tar"
else
echo "Could not create outputs_tar, see docker log for details:"
echo $(${DOCKER} logs $id)
echo $("${DOCKER}" logs $id)
exit 1
fi
${DOCKER} cp $id:%{extract_file} %{output}
${DOCKER} rm $id
"${DOCKER}" cp $id:%{extract_file} %{output}
"${DOCKER}" rm $id

# If a data volumn is created, delete it at the end.
%{clean_data_volume_cmd}