Quote docker cli path to support Windows paths with spaces#877
Merged
smukherj1 merged 1 commit intobazelbuild:masterfrom May 22, 2020
greenhouse-org:quote-docker-tool-path
Merged
Quote docker cli path to support Windows paths with spaces#877smukherj1 merged 1 commit intobazelbuild:masterfrom greenhouse-org:quote-docker-tool-path
smukherj1 merged 1 commit intobazelbuild:masterfrom
greenhouse-org:quote-docker-tool-path
Conversation
Co-authored-by: William A Rowe Jr <wrowe@pivotal.io>
sunjayBhatia
requested review from
alex1545,
nlopezgi,
rbe-toolchains-pr-bot and
smukherj1
as code owners
Contributor
Author
|
cc @wrowe |
Collaborator
|
/gcbrun |
Contributor
Author
that is 100% my feeling, at the last step we run into this in CI b/c docker is installed in Program Files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise if Docker is in "Program Files" or another directory with spaces, bash fails to execute it with an error:
./run_and_extract.sh: line 35: C:/Program: No such file or directory