compilepkg: use absoluate path for tmpdir for x_files#2644
Closed
ukai wants to merge 1 commit intobazel-contrib:masterfrom
Closed
compilepkg: use absoluate path for tmpdir for x_files#2644ukai wants to merge 1 commit intobazel-contrib:masterfrom
ukai wants to merge 1 commit intobazel-contrib:masterfrom
Conversation
compilepkg failed on windows bazel-out/host/bin/external/go_sdk/builder.exe compilepkg -sdk external/go_sdk -installsuffix windows_amd64 -src external/org_golang_google_protobuf/internal/encoding/messageset/messageset.go -arc google.golang.org/protobuf/encoding/protowire=google.golang.org/protobuf/encoding/protowire=bazel-out/x64_windows-opt-exec-B51C0BA3-ST-c3a8cc05bdea9a638dbef813eeba1ffe0dfa7d81daedbab406d39b734127c092/bin/external/org_golang_google_protobuf/encoding/protowire/protowire.x -arc google.golang.org/protobuf/internal/errors=google.golang.org/protobuf/internal/errors=bazel-out/x64_windows-opt-exec-B51C0BA3-ST-c3a8cc05bdea9a638dbef813eeba1ffe0dfa7d81daedbab406d39b734127c092/bin/external/org_golang_google_protobuf/internal/errors/errors.x -arc google.golang.org/protobuf/reflect/protoreflect=google.golang.org/protobuf/reflect/protoreflect=bazel-out/x64_windows-opt-exec-B51C0BA3-ST-c3a8cc05bdea9a638dbef813eeba1ffe0dfa7d81daedbab406d39b734127c092/bin/external/org_golang_google_protobuf/reflect/protoreflect/protoreflect.x -arc google.golang.org/protobuf/reflect/protoregistry=google.golang.org/protobuf/reflect/protoregistry=bazel-out/x64_windows-opt-exec-B51C0BA3-ST-c3a8cc05bdea9a638dbef813eeba1ffe0dfa7d81daedbab406d39b734127c092/bin/external/org_golang_google_protobuf/reflect/protoregistry/protoregistry.x -importpath google.golang.org/protobuf/internal/encoding/messageset -p google.golang.org/protobuf/internal/encoding/messageset -package_list bazel-out/host/bin/external/go_sdk/packages.txt -o bazel-out/x64_windows-opt-exec-B51C0BA3-ST-c3a8cc05bdea9a638dbef813eeba1ffe0dfa7d81daedbab406d39b734127c092/bin/external/org_golang_google_protobuf/internal/encoding/messageset/messageset.a -x bazel-out/x64_windows-opt-exec-B51C0BA3-ST-c3a8cc05bdea9a638dbef813eeba1ffe0dfa7d81daedbab406d39b734127c092/bin/external/org_golang_google_protobuf/internal/encoding/messageset/messageset.x -gcflags -asmflags ERROR: C:/src/home/ukai/_bazel_ukai/tmh4tcb4/external/org_golang_google_protobuf/internal/encoding/messageset/BUILD.bazel:3:11: GoCompilePkg external/org_golang_google_protobuf/internal/encoding/messageset/messageset.a failed (Exit 1) compilepkg: mkdir bazel-out\x64_windows-opt-exec-B51C0BA3-ST-c3a8cc05bdea9a638dbef813eeba1ffe0dfa7d81daedbab406d39b734127c092\bin\external\org_golang_google_protobuf\internal\encoding\messageset\x_files303035073: The filename or extension is too long. Use absolute path for temp directory for x_files Fixes: bazel-contrib#2641
Collaborator
|
Thanks for working on this, but I think #2648 is a better way to go. We didn't actually need that extra temp directory. |
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
Calls to the modules mapping rule contains very long command line args due to the use of the full `wheels` parameter. This change adds support for spilling the args into a file as needed. In addition, it improves the performance of the `modules_mapping` rule: * Remove the calls `to_list` that are unnecessary on the depset. * Remove the iteration over the depset when passing to `args`, and other calls to `.path`, and instead let args do this lazily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
compilepkg failed on windows
Use absolute path for temp directory for x_files
Which issues(s) does this PR fix?
Fixes #2641
Other notes for review