Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding descriptor dependency to gogo proto compiler #2529

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Adding descriptor dependency to gogo proto compiler #2529

merged 1 commit into from
Jun 5, 2020

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Jun 5, 2020 •
edited
Loading

Similar to #2160, adding descriptor to the gogo proto compiler without grpc

Fixes #1385

@linzhp linzhp requested a review from jayconrod as a code owner June 5, 2020 00:27
jayconrod
jayconrod approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. I have to give the disclaimer though: I don't know much about gogo and can't offer much support.

@jayconrod jayconrod merged commit 34fe09c into bazel-contrib:master Jun 5, 2020
@linzhp linzhp deleted the descriptor branch June 5, 2020 17:03
jayconrod pushed a commit that referenced this pull request Jul 8, 2020
@linzhp
Adding descriptor dependency to gogo proto compiler (#2529)
563d500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayconrod jayconrod jayconrod approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@linzhp @jayconrod @googlebot