Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gogo proto descriptor to deps of gogo proto compiler #2160

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Jul 25, 2019

Some of the proto-generated code depends on "github.com/gogo/protobuf/protoc-gen-gogo/descriptor", leading to the follow error a build time. This PR fixes it.

import of "github.com/gogo/protobuf/protoc-gen-gogo/descriptor"
Known dependencies are:
	github.com/gogo/protobuf/gogoproto
	github.com/gogo/protobuf/proto
	github.com/gogo/protobuf/sortkeys
	github.com/gogo/protobuf/types
	google.golang.org/grpc
	golang.org/x/net/context
	github.com/golang/protobuf/ptypes/any
	google.golang.org/genproto/protobuf/api
	github.com/golang/protobuf/protoc-gen-go/plugin
	github.com/golang/protobuf/protoc-gen-go/descriptor
	github.com/golang/protobuf/ptypes/duration
	github.com/golang/protobuf/ptypes/empty
	google.golang.org/genproto/protobuf/field_mask
	google.golang.org/genproto/protobuf/source_context
	github.com/golang/protobuf/ptypes/struct
	github.com/golang/protobuf/ptypes/timestamp
	google.golang.org/genproto/protobuf/ptype
	github.com/golang/protobuf/ptypes/wrappers
Check that imports in Go sources match importpath attributes in deps.

@robbertvanginkel
Copy link
Contributor

I believe this fixes #1385

Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jayconrod jayconrod merged commit 4c28450 into bazel-contrib:master Jul 29, 2019
@linzhp linzhp deleted the gogo branch July 29, 2019 16:32
jayconrod pushed a commit to jayconrod/rules_go that referenced this pull request Aug 23, 2019
jayconrod pushed a commit to jayconrod/rules_go that referenced this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants