implements support for buildmode=plugin + test suite (#539) #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayconrod
reviewed
Jun 14, 2018
go/private/actions/link.bzl
Outdated
| @@ -63,6 +64,8 @@ def emit_link( | |||
| if go.mode.link != LINKMODE_NORMAL: | |||
| builder_args.add(["-buildmode", go.mode.link]) | |||
| tool_args.add(["-linkmode", "external"]) | |||
| if go.mode.link == LINKMODE_PLUGIN: | |||
| builder_args.add(["-pluginpath", archive.data.importpath]) | |||
There was a problem hiding this comment.
Add to tool_args instead of builder_args here. The builder doesn't need to interpret this flag/
go/tools/builders/link.go
Outdated
| @@ -39,6 +39,7 @@ func run(args []string) error { | |||
| main := flags.String("main", "", "Path to the main archive.") | |||
| outFile := flags.String("o", "", "Path to output file.") | |||
| buildmode := flags.String("buildmode", "", "Build mode used.") | |||
| pluginPath := flags.String("pluginpath", "", "Full path name for plugin (for linker).") | |||
There was a problem hiding this comment.
You should be able to remove this flag. The rule should only pass it through the tool args if it's needed, so no reason to filter it here.
|
Done 👍 |
jayconrod
approved these changes
Jun 15, 2018
ArielleA
pushed a commit
to ArielleA/rules_go
that referenced
this pull request
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.