Skip to content

fix: update_deleted_packages is now deterministic #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: update_deleted_packages is now deterministic #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/find_child_workspace_packages.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,4 @@ while IFS=$'\n' read -r line; do sorted_abs_path_pkgs+=("$line"); done < <(
# Strip the workspace_root prefix from the paths
pkgs=( "${sorted_abs_path_pkgs[@]#"${workspace_root}/"}")

print_by_line "${pkgs[@]}"
print_by_line "${pkgs[@]}" | sort
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this should be sorted already on lines 109-112. Can you capture an example where it is not sorted? A fix may need to be applied to sort_items.