fix: update_deleted_packages is now deterministic #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that this was causing issues for some of the rules_pythons hooks. Hopefully the sort allows us to be more deterministic no matter how the files are ordered.
cgrindel
reviewed
Aug 18, 2025
| pkgs=( "${sorted_abs_path_pkgs[@]#"${workspace_root}/"}") | ||
|
|
||
| print_by_line "${pkgs[@]}" | ||
| print_by_line "${pkgs[@]}" | sort |
There was a problem hiding this comment.
It looks like this should be sorted already on lines 109-112. Can you capture an example where it is not sorted? A fix may need to be applied to sort_items.
|
Ah I think rules_python is on an old version of bazel_starlib that didn't have |
|
Ah sorry for that, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this was causing issues for some of the rules_pythons
hooks. Hopefully the sort allows us to be more deterministic no matter
how the files are ordered.