Skip to content

Make helper tool build deterministic #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayconrod merged 1 commit into from
Nov 27, 2018
Merged

Make helper tool build deterministic #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion internal/go_repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,21 @@ def _go_repository_tools_impl(ctx):
"GOPATH": str(ctx.path(".")),
# workaround: to find gcc for go link tool on Arm platform
"PATH": ctx.os.environ["PATH"],
# workaround: avoid the Go SDK paths from leaking into the binary
"GOROOT_FINAL": "GOROOT",
# workaround: avoid cgo paths in /tmp leaking into binary
"CGO_ENABLED": "0",
}

for tool in ("fetch_repo", "gazelle"):
args = [go_tool, "install", "github.com/bazelbuild/bazel-gazelle/cmd/{}".format(tool)]
args = [
go_tool, "install",
"-a",
"-ldflags", "-w -s",
"-gcflags", "all=-trimpath=" + env["GOPATH"],
"-asmflags", "all=-trimpath=" + env["GOPATH"],
"github.com/bazelbuild/bazel-gazelle/cmd/{}".format(tool),
]
result = env_execute(ctx, args, environment = env)
if result.return_code:
fail("failed to build {}: {}".format(tool, result.stderr))
Expand Down