Make helper tool build deterministic#382
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Nov 27, 2018
Merged
Conversation
jayconrod
approved these changes
Nov 27, 2018
Contributor
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Looks good. go_repository doesn't really support bazel sync yet (we'll probably eventually want to specify a go.mod-style version pattern or something), but more deterministic is better. Thanks!
Contributor
Author
|
Thanks for the quick response! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the builds for helper utilities
fetch_repoandgazellearen't deterministic, and have hashes that change depending on where they're built. Since these are built as repository rules, it makes it tricky to prefetch dependencies usingbazel sync, since the hash of dependencies will change per-build.These changes build the helper utilities with the appropriate set of flags to ensure that they're deterministic; this can be tested by running
strings path-to-gazelle | egrep '(\/bazel\/|\/tmp\/)'.Let me know if this works for you folks! All tests pass locally on Linux with these changes.