Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow temp functions to also be run setup_file and teardown_file #36

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

NickLarsenNZ
Copy link

Allow temp_make and temp_del to be run in setup_file and teardown_file

Fixes #35

@NickLarsenNZ
Copy link
Author

I'm just adding tests now

@NickLarsenNZ
Copy link
Author

I've just followed the existing pattern, but might need someone more familiar with bats-file to take a closer look.
Also, looks like the tests fail for reasons mentioned in #31

@jlisee
Copy link

jlisee commented Apr 29, 2021

@NickLarsenNZ I would love this fix, do you think you could get the CI build passing?

@NickLarsenNZ
Copy link
Author

Hi @jlisee, I took a look at the issue I linked above and it is still open and unresolved.

When I'm at my laptop I'll rebase and check. Maybe I'll look at the cause of the test failures and try to resolve the other ticket before progressing this one.

@NickLarsenNZ
Copy link
Author

NickLarsenNZ commented May 2, 2021

I had a quick look at the existing CI issues and I wonder if it's a problem with batslib_is_caller from over in https://github.com/bats-core/bats-support.

Maybe @sublimino might know?
Maybe in the meantime those failing tests can be skipped so PRs can progress. In saying that, it looks like there's not a lot of movement on this repo judging by the length of time the open PRs have been sitting here.

@martin-schulze-vireso
Copy link
Member

I rebased onto current master to get the CI fixes in.

@martin-schulze-vireso martin-schulze-vireso merged commit f01c4b9 into bats-core:master Mar 6, 2022
@martin-schulze-vireso
Copy link
Member

Thanks for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to run temp_make in the setup_file block.
3 participants