Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temp del #31

Merged
merged 5 commits into from
Mar 6, 2022
Merged

Conversation

tralston
Copy link

Allows removing of files on Mac without hanging. Includes test.

src/temp.bash Outdated Show resolved Hide resolved
@sublimino
Copy link
Member

A few tests failing here please @tralston 🙏

@Vampire
Copy link

Vampire commented Jul 14, 2020

A few tests failing here please @tralston 🙏

While it would be great if they get fixed,
the failing tests are not because of this PR, just if anyone wonders.
The build is failing since the last merge which was just a documentation change.
But the execution environment changed from trusty to xenial, so this could be actually a bug that happens on newer systems.

tralston and others added 2 commits March 6, 2022 23:30
…sent in the temporary directory created by temp_make. Added test.
Per comment [here](bats-core/bats-core#276 (comment)) by @Vampire, piped commands aren't necessary when main command has arguments that cover the use case.
@martin-schulze-vireso martin-schulze-vireso force-pushed the fix-temp_del branch 3 times, most recently from 2aefe24 to 201ef56 Compare March 6, 2022 23:08
@martin-schulze-vireso martin-schulze-vireso merged commit ad052a6 into bats-core:master Mar 6, 2022
@martin-schulze-vireso
Copy link
Member

Thanks for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants