Skip to content

Conversation

@hmmr
Copy link
Contributor

@hmmr hmmr commented Feb 7, 2017

RTS-545, RTS-1165 (MEDIAN); RTS-1173, RTS-1553 (PERCENTILE); RTS-547, RTS-1222 (MODE)

Depends on basho/riak_kv#1624.

Tests for inverse distribution functions: PERCENTILE_DISC, PERCENTILE_CONT, MEDIAN, MODE.

@hmmr hmmr force-pushed the feature-az-percentile branch from 25c7e59 to 2c147fe Compare February 11, 2017 16:37
@hmmr hmmr changed the title [WIP] new module ts_simple_percentile new module ts_simple_percentile Feb 11, 2017
@gordonguthrie
Copy link
Contributor

Is this PR agains the right base? surely riak_ts-develop?

@hmmr hmmr changed the base branch from develop to riak_ts-develop February 20, 2017 13:29
@hmmr
Copy link
Contributor Author

hmmr commented Feb 20, 2017

Changed base.

Copy link

@hazen hazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to switch back changes to a bash script

git config --local core.safecrlf false
git config --local core.filemode true
fi
git config --local user.name "Riak Test"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert these changes to this script? It is supposed to work on different versions of git now

@macintux
Copy link
Contributor

Would suggest including a test of a table where the column to be measured is defined as descending in the DDL.

@hmmr
Copy link
Contributor Author

hmmr commented Feb 27, 2017

@macintux now testing on tables with keys declared DESC, in aa4b672.

@macintux
Copy link
Contributor

+1

@hazen hazen merged commit 5e3b102 into riak_ts-develop Feb 28, 2017
@hazen hazen deleted the feature-az-percentile branch February 28, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants