inverse distribution functions (PERCENTILE_{DISC,CONT}, MEDIAN, MODE) #1624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hmmr! Settings---
minimum_reviewers: 2
merge: true
build_steps:
- make clean
- make deps
- make compile
- make test
- make xref
- make dialyzer
org_mode: true
timeout: 1800 |
There seems to be an issue with build step **make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
This was referenced Feb 7, 2017
hmmr
changed the title
hmmr
changed the title
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
hmmr
force-pushed
the
feature-az-percentile
branch
from
48c073c to
0b60938
Compare
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
hmmr
changed the title
Contributor
Author
|
added 2 commits
February 12, 2017 01:07
hmmr
force-pushed
the
feature-az-percentile
branch
from
0b60938 to
876fb98
Compare
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
hmmr
changed the title
with fixes for static expression evaluation in function parameters
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
hmmr
changed the title
| {reply, {ok, {ColNames, ColTypes, Rows}}, State9} | ||
| end. | ||
|
|
||
| maybe_supply_offset([]) -> [0]; |
There was a problem hiding this comment.
Thing isn't a great variable name
src/riak_kv_app.erl
Outdated
| [true, false], | ||
| false), | ||
|
|
||
| riak_core_capability:register({riak_kv, inverse_distrib_functions_supported}, |
There was a problem hiding this comment.
This is redundant - there is no upgrade downgrade...
|
Review of the unit tests in |
src/riak_kv_qry_compiler.erl
Outdated
| %% possible other such columns and converted to the actual function in | ||
| %% `compile_order_by`. | ||
| prepare_invdist_funcall(FnName, [{identifier, [ColumnArg]}|_] = Args) -> | ||
| case riak_core_capability:get({riak_kv, inverse_distrib_functions_supported}) of |
There was a problem hiding this comment.
Here is the rogue capability call
hmmr
force-pushed
the
feature-az-percentile
branch
from
90fb2cc to
bd497b8
Compare
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
There seems to be an issue with build step **merge,make_compile,make_test,make_xref,make_dialyzer** ! ☁️⛔ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
⛔ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
added 2 commits
February 27, 2017 23:19
# Conflicts: # src/riak_kv_qry_compiler.erl
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
|
+1 |
There seems to be an issue with build step **merge,make_compile,make_test,make_xref,make_dialyzer** ! ☁️⛔ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
⛔ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
hmmr
force-pushed
the
feature-az-percentile
branch
from
becb69d to
0bd882b
Compare
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
added 2 commits
March 2, 2017 03:03
# Conflicts: # src/riak_kv_qry_compiler.erl
hmmr
force-pushed
the
feature-az-percentile
branch
from
0bd882b to
ac22721
Compare
There seems to be an issue with build step **make_test,make_xref,make_dialyzer** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
⛔ MAKE_XREF
⛔ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
macintux
reviewed
Mar 2, 2017
src/riak_kv_qry_compiler.erl
Outdated
| %% we allow multiple PERCENTILE calls in a single SELECT, | ||
| %% but they all must have the same column argument | ||
| case lists:usort(CompiledOrderBys) of | ||
| [_SameColumndOrderBy] -> |
Contributor
There was a problem hiding this comment.
Nit, but it might be important to understand the case clause: there's an apparently-extraneous d in the binding name, _SameColumndOrderBy
macintux
reviewed
Mar 2, 2017
src/riak_kv_qry_compiler.erl
Outdated
| %% convert successfully validated invdist funcalls (a list of them, | ||
| %% to allow for percentile(x, 0.42), percentile(y, 0.24)) into a list | ||
| %% of ORDER BYs, LIMITs and OFFSETs; or report validation errors if any. | ||
| compile_inverdist_funcalls_to_orderby(InvDistFuns) -> |
Contributor
There was a problem hiding this comment.
Since we only report the first error anyway, and since a map would be easier to read than a fold, is there any reason we can't use a map with a throw on error?
Contributor
Author
There was a problem hiding this comment.
Reduced the foldl into two elegant list comprehensions in b094470.
|
|
👍 |
|
thumbot retry |
Looks good! 👍✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
✅ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 1 of 2 Code reviews from organization basho
|
|
+1 |
✅ 2 of 2 Code reviews from organization basho
|
|
Merging and closing this pr |
|
Successfully merged basho/riak_kv/pulls/1624 (b094470 on to riak_ts-develop) ---
:sha: 11ac6663cf59635f4392a997c55f03eaa9e25651
:merged: true
:message: Pull Request successfully merged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTS-545, RTS-1165 (MEDIAN); RTS-1173, RTS-1553 (PERCENTILE); RTS-547, RTS-1222 (MODE)
RFC in basho/rfc#55. Depends on basho/riak_ql#167. Tests in basho/riak_test#1270.
Support for inverse distribution functions, currently including PERCENTILE_DISC, PERCENTILE_CONT, MEDIAN and MODE.
Additionally, a fix for a div-by-zero hiccup that happens when the first chunk received by the coordinator has zero rows.