Fix Castables issue #1312 #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mfn
approved these changes
Feb 2, 2023
# Conflicts: # CHANGELOG.md
Thanks and sorry, that's my first ever PR to an Open Source repo so I'm not always sure about the protocol. I added the |
|
Thanks! |
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* Return Castable class if failed to detect it from return types * fix-style * Add CHANGELOG.md entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for issue with Castables described in #1312
If type of a
Castablecan not be determined from return type of get method fromcastUsing()->CastsAttributesthen the originalCastableclass should be used.Type of change
Checklist
composer fix-style