Around v2.12.0 @property for custom Castables stopped working

[kwarcu]

In v2.11.0, model like this

class Job extends Model
{
    protected $fillable = [
        'status',
    ];

    protected $casts = [
        'status' => JobStatus::class,
    ];
[...]

would generate phpdoc @property JobStatus $status, but since v2.12.0 it keeps generating @property mixed $status

Exact command I'm using is php artisan ide-helper:models --write --smart-reset

It was fine in v2.11.0, currently using this exact version locked

[innocenzi]

Not sure if it's related, but using https://github.com/spatie/laravel-data, a similar issue happens:

protected $casts = [
    'legacy' => LegacyUserData::class,
];

The generated property is @property \Spatie\LaravelData\Data|null|null $legacy instead of @property Domain\Legacy\DTO\LegacyUserData|null $legacy

[seanmtaylor]

Same here. We're still on v2.11.0 for this very reason. All of our custom casts are being changed to mixed.

[mfn]

Is this still an issue with the latest version?

I think #1306 is the reason, but there was a hotfix release shortly afterwards…

[kwarcu]

Is this still an issue with the latest version?

Just checked v2.12.3 and issue still exists.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

[kwarcu]

v2.12.3 is still the latest version and issue still exists for latest Laravel version.

[aaronflorey]

I'm not quite sure on the rules of accepting code here, but would the maintainers accept a PR that hard codes in a check for LaravelData?

        if(get_parent_class($type) === 'Spatie\LaravelData\Data') {
            return $type;
        }

[AlexeyKosov]

Anybody found a way to fix that?

[kwarcu]

Anybody found a way to fix that?

Still nothing. I never got to debugging the lib itself though. FWIW problem still exists on latest version 🤷‍♂️

[kwarcu]

Had enough of it and finally I created a bugfix for the issue, PR: #1388