docs: add ROADMAP.md, TZ.md, and AGENT_QUICKSTART.md for agent handoff#617
Merged
barach6662001-bit merged 2 commits intomainfrom Apr 24, 2026
Merged
docs: add ROADMAP.md, TZ.md, and AGENT_QUICKSTART.md for agent handoff#617barach6662001-bit merged 2 commits intomainfrom
barach6662001-bit merged 2 commits intomainfrom
Conversation
💡 Codex ReviewLines 16 to 17 in b4d332a  Include PR #608 in completed roadmap history
The new Line 141 in b4d332a  Align PR #615 scope in plan.md with roadmap
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
barach6662001-bit
added a commit
that referenced
this pull request
Apr 25, 2026
…640) * docs(roadmap): correct currency conversion v2 PR number (#632 → #634) and note switcher is re-enabled * chore(roadmap): split PR #614 into core + #614a (system) + #614b (catalogs) + #614c (broadcast) PR #614 scope as a single ticket was too broad (3 admin pages + impersonation engine + audit log + global users + 4 sub-features each non-trivial). Split into a sequenced set so each is reviewable: - #614 (in progress): impersonation engine + /admin/users + /admin/audit-log + 6 integration tests + red banner + rate limit + forbidden-action filter - #614a: /admin/system read-only health dashboard + audit-log CSV export - #614b: /admin/catalogs (global reference data CRUD) - #614c: /admin/broadcast (depends on PR #617 notifications fixes) TZ.md status marker updated to reflect the split. * feat(impersonation): backend engine, JWT extension, forbidden-action filter, /admin/users + audit-log filters - ICurrentUserService gains IsImpersonating + ImpersonatedByUserId - JwtTokenService.GenerateImpersonationToken issues a 60min token with claims is_super_admin=false, impersonated_by_user_id, original_tenant_id, impersonation_reason - IImpersonationService + ImpersonationService: * StartAsync: validates target (not self, not super-admin, active), enforces 3/24h rate limit by querying SuperAdminAuditLog, audits 'impersonate.start', inserts in-app Notification (severity warning, body in Ukrainian with Kyiv timestamp + reason), best-effort email * EndAsync: requires impersonated_by_user_id claim, audits 'impersonate.end', re-issues a fresh super-admin token for the original admin * LogForbiddenAttemptAsync: writes 'impersonate.forbidden_attempt' audit row - ForbiddenDuringImpersonationAttribute (filter): on 403 also writes the forbidden-attempt audit row with the attempted route. Applied to: AuthController.ChangePassword, ApiKeysController create + revoke, UsersController.UpdateUserRole + ResetUserPassword - ImpersonationController: POST /api/admin/impersonate (super-admin only), POST /api/admin/impersonate/end (callable from impersonation token) - AdminController: GET /api/admin/users (global search across tenants with tenant name), GET /api/admin/audit-log gains action / adminUserId / fromUtc / toUtc / tenantId filters * feat(impersonation): add partial composite index for rate-limit query CREATE INDEX ix_superadminauditlogs_impersonation_ratelimit ON SuperAdminAuditLogs (AdminUserId, TargetId, OccurredAt DESC) WHERE Action = 'impersonate.start' Backs the 3/24h-per-(admin,target) rate-limit lookup in ImpersonationService.StartAsync. Partial filter keeps the index small as the audit log grows across all super-admin actions. * test(impersonation): 6 integration scenarios + extend TestAuthHandler with X-Test-ImpersonatedBy - (1) non-super-admin caller -> 403 - (2) super-admin without MFA -> 403 + X-Mfa-Required - (3) happy path -> 200 + 60min token + audit row + Notification row (Ukrainian title 'Сесія імперсонації', warning severity, body contains the reason) - (4) reason < 10 chars -> 400 - (5) rate limit: 4th impersonation in 24h on same target -> 429 (3 prior 'impersonate.start' rows pre-seeded directly into SuperAdminAuditLogs to keep the test deterministic and fast) - (6) forbidden action under impersonation token (POST /api/auth/change-password) -> 403 AND writes a separate 'impersonate.forbidden_attempt' audit row TestAuthHandler now also accepts X-Test-ImpersonatedBy for forbidden-action coverage, matching the JWT contract (impersonation tokens always carry is_super_admin=false). All 441 tests pass (315 unit + 126 integration). * feat(frontend): super-admin impersonation banner + /admin/users + /admin/audit-log - authStore: add impersonation slice (target + original snapshots, expires) - api/admin: startImpersonation / endImpersonation / listAdminUsers / listAdminAuditLog - ImpersonationBanner: red, non-closable, z-index 9999, full viewport, countdown, exit restores original token - /admin/users: global users table with reason modal (>=10 chars) + impersonate - /admin/audit-log: filtered audit log with expandable payload - i18n keys (uk + en) for users page, audit log, banner, modal * fix(impersonation): default-impl IsImpersonating/ImpersonatedByUserId on ICurrentUserService Avoids breaking 5 unit-test stubs (FakeCurrentUserService + per-test TestCurrentUserService) without forcing them to update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures completed work across PR #602-611, remaining scope across PR #612-617, locked architectural decisions, technical debt, and agent protocol.