Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to set broker group specific labels to Kafka broker pods #803

Merged
merged 11 commits into from
May 3, 2022
Merged

Add support to set broker group specific labels to Kafka broker pods #803

merged 11 commits into from
May 3, 2022

Conversation

panyuenlau
Copy link
Member

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #605
License Apache 2.0

What's in this PR?

Add a new optional field to KafkaCluster spec: brokerConfigGroups.<group>.brokerLabels that's appended to the current list of pod labels when set

Why?

Community request

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@panyuenlau panyuenlau requested a review from a team as a code owner April 27, 2022 20:51
stoader
stoader requested changes Apr 28, 2022
View reviewed changes
bartam1
bartam1 reviewed Apr 28, 2022
View reviewed changes
Copy link
Contributor

@bartam1 bartam1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if changes will be applied

amberimam
amberimam reviewed May 2, 2022
View reviewed changes
Copy link

@amberimam amberimam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the work. Just found a couple of things that would make the code a little more readable.

stoader
stoader previously approved these changes May 2, 2022
View reviewed changes
amberimam
amberimam previously approved these changes May 2, 2022
View reviewed changes
@panyuenlau panyuenlau dismissed stale reviews from amberimam and stoader via 512bba3 May 2, 2022 18:39
@panyuenlau panyuenlau merged commit 504844f into banzaicloud:master May 3, 2022
@panyuenlau panyuenlau deleted the broker-labels branch May 3, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartam1 bartam1 bartam1 left review comments

@stoader stoader stoader approved these changes

@pregnor pregnor pregnor approved these changes

@amberimam amberimam amberimam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to set brokerGroup specific labels to kafka pods
5 participants
@panyuenlau @amberimam @stoader @pregnor @bartam1