Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to set brokerGroup specific labels to kafka pods #605

Closed
amuraru opened this issue May 11, 2021 · 2 comments · Fixed by #803
Closed

Add support to set brokerGroup specific labels to kafka pods #605

amuraru opened this issue May 11, 2021 · 2 comments · Fixed by #803
Assignees
Labels
community enhancement New feature or request

Comments

@amuraru
Copy link
Contributor

amuraru commented May 11, 2021

Is your feature request related to a problem? Please describe.

Currently the operator support setting kafka pods labels via propagateLabels field in the KafkaCluster spec. This way not only the pods but all the created resources will get the labels.
In addition to that it would be useful to have the ability to set kafka pods labels specific for each brokerConfigurationGroup, i.e. kafka_broker_group: group_name
For our use-case this can be used in Prometheus monitoring to capture the group/az for each broker as a label.

Describe the solution you'd like to see

Add a new optional field to KafkaCluster spec: brokerConfigGroups.<group>.brokerLabels that's appended to the current list of pod labels when set.

Describe alternatives you've considered

Currently we are making use of brokerConfigGroups.<group>.brokerAnnotations but this needs additional manipulation in Prometheus ServiceMonitor definition to transform a pod annotation to a metric label.

@baluchicken baluchicken added community enhancement New feature or request labels May 12, 2021
@LukasSlouka
Copy link

Also useful with network policies

@panyuenlau
Copy link
Member

Hey @amuraru @LukasSlouka, this has been added to the operator, see this newly added section about how to configure the kafkacluster to set a group-specific label for the brokers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants