Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 509 #510

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Conversation

teddychao
Copy link
Contributor

@teddychao teddychao commented Aug 10, 2023

Fixes #509.

Changes proposed in this pull request:

  • fix eyelink marker

@teddychao teddychao linked an issue Aug 10, 2023 that may be closed by this pull request
@dominikbach dominikbach added the Bug Something isn't working label Aug 14, 2023
@dominikbach dominikbach added this to the v6.1 milestone Aug 14, 2023
@dominikbach dominikbach marked this pull request as ready for review August 14, 2023 06:54
@dominikbach dominikbach merged commit 1dcacbc into develop Aug 14, 2023
1 check passed
@dominikbach dominikbach deleted the 509-eyes-observed-incorrectly-inherit-eye-marker branch August 14, 2023 06:55
@teddychao
Copy link
Contributor Author

Hi @dominikbach I am sorry, I have not tested this pull request fully. We approved previously that only the pull requests with the mark "completed and waiting for review" should be approved and merged, and I had not added that marker to this pull request.

@teddychao teddychao added Solved and removed Bug Something isn't working labels Aug 20, 2023
@teddychao teddychao removed the Solved label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eyes observed incorrectly inherit eye marker
2 participants