Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 500 -- pspm_interp1 #501

Conversation

teddychao
Copy link
Contributor

@teddychao teddychao commented Jul 7, 2023

Introduction

Users reported an issue when the input data contains NaNs. The issues is caused by the approach of calculating mean and interpolating at pspm_resp_pp, pspm_prepdata, pspm_interp1. The expected behaviour is listed as below:

  1. In pspm_interp1, interpolation should be performed if the data contains at least two non-NaN values.
  2. Data as the input of pspm_prepdata should be carefully checked to avoid being converted into NaNs due to other calculations, for example calculating the mean.
    The pull request fixes pspm_interp1 needs to consider data without valid values #500.

Results

Changes proposed in this pull request:

  • Update pspm_interp1
    • Add data checking for pspm_interp1.
  • Update pspm_resp_pp
    • Avoid NaN converting when performing mean-based filtering.

@teddychao teddychao linked an issue Jul 7, 2023 that may be closed by this pull request
@teddychao teddychao changed the title Add data checking for pspm_interp1 Fix issue 500 -- pspm_interp1 Jul 7, 2023
@teddychao teddychao self-assigned this Jul 7, 2023
@teddychao teddychao marked this pull request as ready for review July 10, 2023 14:49
@teddychao teddychao added the Completed & Waiting for Review Completed and waiting for review label Jul 10, 2023
@teddychao teddychao added this to the v6.1 milestone Jul 10, 2023
@dominikbach dominikbach merged commit ee483c7 into develop Jul 16, 2023
@dominikbach dominikbach deleted the 500-pspm_interp1-needs-to-consider-data-without-valid-values branch July 16, 2023 13:50
@teddychao teddychao added Solved and removed Completed & Waiting for Review Completed and waiting for review labels Aug 20, 2023
@teddychao teddychao removed the Solved label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pspm_interp1 needs to consider data without valid values
2 participants