Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Users reported an issue when the input data contains NaNs. The issues is caused by the approach of calculating mean and interpolating at
pspm_resp_pp
,pspm_prepdata
,pspm_interp1
. The expected behaviour is listed as below:pspm_interp1
, interpolation should be performed if the data contains at least two non-NaN values.pspm_prepdata
should be carefully checked to avoid being converted into NaNs due to other calculations, for example calculating the mean.The pull request fixes pspm_interp1 needs to consider data without valid values #500.
Results
Changes proposed in this pull request:
pspm_interp1
pspm_interp1
.pspm_resp_pp