Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force LoadingNotificationCommand to execute the then argument on ajax completion #208

Conversation

jvanecek
Copy link
Member

Proposed solution for #207

@jvanecek jvanecek requested review from gcotelli and mtabacman March 31, 2022 15:55
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #208 (b0b0ef4) into release-candidate (ce05e1b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           release-candidate     #208      +/-   ##
=====================================================
- Coverage              99.96%   99.96%   -0.01%     
=====================================================
  Files                    229      229              
  Lines                  22078    22052      -26     
=====================================================
- Hits                   22070    22044      -26     
  Misses                     8        8              
Impacted Files Coverage Δ
...sts/CombinedWebInteractionInterpreterTest.class.st 100.00% <100.00%> (ø)
...Core-Tests/LoadingNotificationCommandTest.class.st 100.00% <100.00%> (ø)
...-Core-Tests/WebInteractionInterpreterTest.class.st 100.00% <100.00%> (ø)
...ce/Willow-Core/LoadingNotificationCommand.class.st 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce05e1b...b0b0ef4. Read the comment docs.

@mtabacman mtabacman merged commit 3501fa5 into release-candidate Apr 1, 2022
@mtabacman mtabacman deleted the 207-LoadingNotificationCommand-may-never-execute-the-then-argument branch April 1, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants