Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadingNotificationCommand may never execute the "then" argument #207

Closed
jvanecek opened this issue Mar 31, 2022 · 1 comment
Closed

LoadingNotificationCommand may never execute the "then" argument #207

jvanecek opened this issue Mar 31, 2022 · 1 comment

Comments

@jvanecek
Copy link
Member

LoadingNotificationCommand it was designed to do an action before an ajax (tipically "display message") and do another when completed (hide said message).

Since the block passed in the #then: key argument is considered a modelLoadingInstruction, it may never be executed if no ajax is configured to the component, leaving the action executed by the serverIndependentAction (defined in the #executing: key argument) not undone.

This could be solved if this command works as TemporarilyDisablingCommand, where both actions are actually one priorityAction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants