fix: add character length dictionary for string length computation in console #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thanks a lot @mkah91 |
ayonious
pushed a commit
that referenced
this pull request
Aug 24, 2022
## [2.11.1](v2.11.0...v2.11.1) (2022-08-24) ### Bug Fixes * add character length dictionary for string length computation in console ([#431](#431)) ([89f6db2](89f6db2)) * dont allow negative numbers in string.repeat ([#422](#422)) ([c9e8994](c9e8994)) * Fix color resetting for borders ([#428](#428)) ([bcb6e8c](bcb6e8c))
|
🎉 This PR is included in version 2.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This is such a cool fix! Really makes tables smile back, hehehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀What is this pr about?
The PR introduces an optional charLength dictionary in the
findWidthInConsolemethod that is used to compute the length of a string in console. With that dictionary you can assign a certain length to a character or a string.🚀 Changes
Fixed
#389
#430
🖼 Screenshots
const bundle = new Table({ title: 'Bundle (BUNDLENAME)', columns: [ { name: 'Weapon' }, { name: 'Chroma' }, { name: 'Quality' }, { name: 'Price' }, ], + charLength: { '👍': 2, '✅': 2 }, }) bundle.addRows([ { Weapon: '👍', Chroma: '✅', Quality: 'Deluxe', Price: '1 775 VP', }, ]) bundle.printTable()