-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying custom color map #394
Conversation
c2e1120
to
ad83a84
Compare
@ayonious I just wanted to open a PR doing the same thing, are you planning to merge this in future versions? |
index.ts
Outdated
|
||
export { Table, printTable, renderTable, COLOR, ALIGNMENT }; | ||
export { Table, printTable, renderTable, COLOR, ALIGNMENT, ColorMap, DEFAULT_COLOR_MAP }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ColorMap does not need to be exported here, is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe DEFAULT_COLOR_MAP also is not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please add at least one test on how to use this.
@ejose19 please fix the above 2 things, then I will test it out. |
I will add the tests later in another PR. |
🎉 This PR is included in version 2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀What is this pr about?
Allow specifying a custom color map, in case the user want to use other colors other than the defaults
Added
👶 The naming of the PR
feat: allow specifying custom color map