Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying custom color map #394

Merged
merged 3 commits into from
Apr 3, 2022

Conversation

ejose19
Copy link
Contributor

@ejose19 ejose19 commented Aug 11, 2021

👀What is this pr about?

Allow specifying a custom color map, in case the user want to use other colors other than the defaults

Added

  • Allow changing the color map

👶 The naming of the PR

feat: allow specifying custom color map

@ejose19
Copy link
Contributor Author

ejose19 commented Oct 2, 2021

@ayonious I've resolved the conflicts after #396 was merged.

@gal664
Copy link

gal664 commented Mar 30, 2022

@ayonious I just wanted to open a PR doing the same thing, are you planning to merge this in future versions?

index.ts Outdated

export { Table, printTable, renderTable, COLOR, ALIGNMENT };
export { Table, printTable, renderTable, COLOR, ALIGNMENT, ColorMap, DEFAULT_COLOR_MAP };
Copy link
Owner

@ayonious ayonious Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ColorMap does not need to be exported here, is it?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe DEFAULT_COLOR_MAP also is not needed?

Copy link
Owner

@ayonious ayonious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add at least one test on how to use this.

@ayonious
Copy link
Owner

@ejose19 please fix the above 2 things, then I will test it out.

@ayonious
Copy link
Owner

ayonious commented Apr 3, 2022

I will add the tests later in another PR.

@ayonious ayonious merged commit 4c6eecd into ayonious:master Apr 3, 2022
ayonious pushed a commit that referenced this pull request Apr 3, 2022
# [2.11.0](v2.10.0...v2.11.0) (2022-04-03)

### Features

* add option to specify initial rows, make add methods chainable, export renderSimpleTable ([#396](#396)) ([6e6d8f3](6e6d8f3))
* allow specifying custom color map ([#394](#394)) ([4c6eecd](4c6eecd))
@ayonious
Copy link
Owner

ayonious commented Apr 3, 2022

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants