Allow for color: false to wipe the colorMap. #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks amazing |
ayonious
reviewed
Nov 4, 2023
src/models/external-table.ts
Outdated
| @@ -32,6 +32,7 @@ export interface ComplexOptions { | |||
| disabledColumns?: string[]; | |||
| computedColumns?: ComputedColumn[]; | |||
| rowSeparator?: boolean; | |||
| color? : boolean; | |||
There was a problem hiding this comment.
@jdmarshall Could you change this name to
shouldDisableColors?: boolean;
instead?
There was a problem hiding this comment.
That doesn't seem to match up with the other arguments, but I'll try.
ayonious
approved these changes
Nov 6, 2023
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #449
👀What is this pr about?
Summary of what this is about
🚀 Changes
Added
Fixed
Updated
🖼 Screenshots
👶 The naming of the PR
chore(deps): some dependency update
feat: Line Width is not limited, previously it was unlimited
fix(technical): Deployment issue with npm is fixed
fix: title names can be decorated