migrate: from efm to null-ls ( #500 #504 )

[CharlesChiuGit]

WIP

[CharlesChiuGit]

Do we need to re-implement FormatToggle autocmd?
Since we only use null-ls for formatting now, it would be much easier if there's some way to disable null-ls temporally.

[CharlesChiuGit]

@aarnphm PTAL

I think it's better to config sources in null-ls since some formatters can also be used as lsp, like markdownlint.
I'm not sure what's being set via mason-null-ls' automatic_setup, so I think it's better to setup the sources by ourselves separately.

[aarnphm]

LGTM. cc @Jint-lzxy when you have bandwidth.

[ayamir]

:FormatToggle and :FormatterToggle haven't been implemented.

[CharlesChiuGit]

@ayamir Have we tried https://github.com/lukas-reineke/lsp-format.nvim before?
It seems pretty handy.

[CharlesChiuGit]

It seems like the old formmatting.lua is more powerful than ls-format.nvim. I think I'll tack it back and modify a bit.

[ayamir]

Yes, but we chose to realize the functions by ourselves later.

[CharlesChiuGit]

Do we need to keep the choice to use the actual LSP's formatting ability instead of only use null-ls from now on?
From a end-user view point, I think it's much easier to only set formatters in null-ls config rather than modify formatting.lua.

How do u guys think?

[CharlesChiuGit]

In my experiment, block_list doesn't seem valid. How do I block a filetype for formatting?（it doesn't seem to be included in the wiki?

[Jint-lzxy]

In my experiment, block_list doesn't seem valid. How do I block a filetype for formatting?（it doesn't seem to be included in the wiki?

@CharlesChiuGit Yep I plan to review & reimplement :FormatToggle and :FormatterToggle by the end of this week 👍 Some interaction logic has changed during this migration.

Do we need to keep the choice to use the actual LSP's formatting ability instead of only use null-ls from now on? From a end-user view point, I think it's much easier to only set formatters in null-ls config rather than modify formatting.lua.

How do u guys think?

Not sure if I understood this question correctly, but IMHO this choice should be left to users. Some individuals' / organizations' projects would prefer to have formatting support provided by the language server (especially if they already have a custom configuration file in use).

FWIW what we can do is remind users of those conflicting format approaches and ask them to confirm their preferences when encountering this for the first time. We can store these results in a cache file, so that the changes made will be persistent. (This is also the feature that will be implemented when refactoring :FormatterToggle)

[CharlesChiuGit]

@Jint-lzxy Then i'll just change efm to null-ls and leave everything else untouched. @ayamir how do u think?

[ayamir]

Agree.

[CharlesChiuGit]

:FormatToggle and :FormatterToggle haven't been implemented.

@ayamir PTAL

[CharlesChiuGit]

side note: I think some of formatting.lua's setting should be port to core/settings.lua. But maybe @Jint-lzxy has already take that into consideration lol

[CharlesChiuGit]

2ff5d96 (#513) moves lsp and null-ls sources tables to core/settings.lua. Will add this to wiki once merged.

[ayamir]

LGTM 👍

[aarnphm]

Feel free to merge it in when it is gtg 😄

[CharlesChiuGit]

I think maybe @Jint-lzxy is reviewing this ATM?