Why not null-ls in this config?

[brxxlstxrs]

Feature description

null-ls is an attempt to reduce the boilerplate required to set up general-purpose language servers and improve performance by removing the need for external processes.

Additional information

maybe you use a substitute for this and I didn't notice, tell me?

[CharlesChiuGit]

Hi, it would be better to ask this kind of questions in https://github.com/ayamir/nvimdots/discussions.

[CharlesChiuGit]

In this config, we use efm to do the linting and formatting.

nvimdots/lua/modules/plugins/completion.lua

Line 8 in a6998ae

{ "creativenull/efmls-configs-nvim" },

nvimdots/lua/modules/configs/completion/lsp.lua

Lines 117 to 176 in a6998ae

	local efmls = require("efmls-configs")
	-- Init `efm-langserver` here.
	efmls.init({
	on_attach = opts.on_attach,
	capabilities = capabilities,
	init_options = { documentFormatting = true, codeAction = true },
	})
	-- Require `efmls-configs-nvim`'s config here
	local vint = require("efmls-configs.linters.vint")
	local eslint = require("efmls-configs.linters.eslint")
	local flake8 = require("efmls-configs.linters.flake8")
	local black = require("efmls-configs.formatters.black")
	local stylua = require("efmls-configs.formatters.stylua")
	local prettier = require("efmls-configs.formatters.prettier")
	local shfmt = require("efmls-configs.formatters.shfmt")
	-- Add your own config for formatter and linter here
	-- local rustfmt = require("completion.efm.formatters.rustfmt")
	local clangfmt = require("completion.efm.formatters.clangfmt")
	-- Override default config here
	flake8 = vim.tbl_extend("force", flake8, {
	prefix = "flake8: max-line-length=160, ignore F403 and F405",
	lintStdin = true,
	lintIgnoreExitCode = true,
	lintFormats = { "%f:%l:%c: %t%n%n%n %m" },
	lintCommand = "flake8 --max-line-length 160 --extend-ignore F403,F405 --format '%(path)s:%(row)d:%(col)d: %(code)s %(code)s %(text)s' --stdin-display-name ${INPUT} -",
	})
	-- Setup formatter and linter for efmls here
	efmls.setup({
	vim = { formatter = vint },
	lua = { formatter = stylua },
	c = { formatter = clangfmt },
	cpp = { formatter = clangfmt },
	python = { formatter = black },
	vue = { formatter = prettier },
	typescript = { formatter = prettier, linter = eslint },
	javascript = { formatter = prettier, linter = eslint },
	typescriptreact = { formatter = prettier, linter = eslint },
	javascriptreact = { formatter = prettier, linter = eslint },
	yaml = { formatter = prettier },
	html = { formatter = prettier },
	css = { formatter = prettier },
	scss = { formatter = prettier },
	sh = { formatter = shfmt },
	markdown = { formatter = prettier },
	-- rust = {formatter = rustfmt},
	})
	formatting.configure_format_on_save()
	end

Then why efm instead of null-ls in the first place? That's b/c efm runs as daemons, and this reduce the startup time when firing up your nvim.

But https://github.com/creativenull/efmls-configs-nvim seems to been not updated in 4 months, maybe it's time to transfer to null-ls?
For:

1. Linters and formatters aren't really LSPs, it's been called only when saved. IMO, it doesn't need to run as daemon in the most case.
2. Null-ls contains wider amount of linters and formatters comparing with efm which is great for users to config new linters and formatters on their own.

@ayamir @Jint-lzxy How do u think?

[CharlesChiuGit]

cc #494

[ayamir]

efm was configured as linters and formatters manager about this time last year. The reason why I use efm is null-ls.nvim just WIP and beta in that time, though it still claims it's in beta state now. We can switch to null-ls.nvim but it's a big change, maybe new version release?

[CharlesChiuGit]

I use null-ls in my personal config for quite a while, and get no problem at all. In fact, we don't need lua/modules/configs/completion/formatting.lua if we set null-ls properly. Will draft a pr after I finished #495