Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more Cysharp.Text classes used in SmartFormat namespace #228

Merged
merged 8 commits into from
Nov 17, 2021

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Nov 17, 2021

Created ZStringBuilder as a wrapper around Utf16ValueStringBuilder
Replaced occurrences of Utf16ValueStringBuilder with ZStringBuilder.
Affects IOutput, NullOutput, StringOutput, TextWriterOoutput, ZStringOutput

axunonb and others added 8 commits November 2, 2021 22:14
commit a8dec64
Merge: ebb820c c4f0115
Author: axunonb <[email protected]>
Date:   Tue Nov 2 21:55:35 2021 +0100

    Merge branch 'axuno:main' into main

commit c4f0115
Author: axunonb <[email protected]>
Date:   Tue Nov 2 21:54:46 2021 +0100

    Delete .github/workflows directory

commit 3283ba9
Author: axunonb <[email protected]>
Date:   Tue Nov 2 17:05:09 2021 +0100

    Remove demo projects

commit 0ebf3f4
Author: axunonb <[email protected]>
Date:   Tue Nov 2 16:30:42 2021 +0100

    Corrected path to test project

commit a9a79d1
Author: axunonb <[email protected]>
Date:   Tue Nov 2 16:22:48 2021 +0100

    Add AltCover to test

commit 608533f
Author: axunonb <[email protected]>
Date:   Tue Nov 2 16:07:01 2021 +0100

    Update build.yml

commit 3005692
Author: axunonb <[email protected]>
Date:   Tue Nov 2 15:00:06 2021 +0100

    Update build.yml

commit 4683d59
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:23:29 2021 +0100

    Update build.yml

commit d3f9b68
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:19:05 2021 +0100

    Update build.yml

commit 4ac19ea
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:11:42 2021 +0100

    Update build.yml

commit ef76dba
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:08:13 2021 +0100

    Update build.yml

commit e2406b4
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:01:07 2021 +0100

    Update build.yml

commit adee45a
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:00:40 2021 +0100

    Update build.yml

commit 5464bb9
Author: axunonb <[email protected]>
Date:   Tue Nov 2 13:53:50 2021 +0100

    Create build.yml

commit ebb820c
Merge: 365bbd0 ca28b30
Author: axunonb <[email protected]>
Date:   Thu Oct 21 10:06:49 2021 +0200

    Merge branch 'axuno:main' into main

commit ca28b30
Author: axunonb <[email protected]>
Date:   Thu Oct 21 10:05:03 2021 +0200

    Backport fixes from v3 (axuno#213)

    Bumped version to 2.7.1

    Back-ported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 365bbd0
Author: axunonb <[email protected]>
Date:   Thu Oct 21 09:16:12 2021 +0200

    Bumped version to 2.7.1

    Backported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 3165fc7
Author: axunonb <[email protected]>
Date:   Thu Oct 21 08:03:32 2021 +0200

    Updated NuGet secure key

commit 8169585
Author: axunonb <[email protected]>
Date:   Sun Sep 5 23:09:38 2021 +0200

    Update README.md

commit 1e09b6a
Author: axunonb <[email protected]>
Date:   Mon Aug 30 01:52:50 2021 +0200

    Update README.md

commit 8954f3e
Author: axunonb <[email protected]>
Date:   Mon Aug 30 01:51:32 2021 +0200

    Update README.md

commit a16b01c
Author: axunonb <[email protected]>
Date:   Tue Jun 15 00:06:03 2021 +0200

    Update README.md

commit d9462f5
Author: axunonb <[email protected]>
Date:   Tue Jun 15 00:05:17 2021 +0200

    Update README.md
* Create ZStringBuilder as a 1:1 wrapper for Utf16ValueStringBuilder
* Replace usage of Utf16ValueStringBuilder by ZStringBuilder
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #228 (212eac2) into version/v3.0 (ed6c5eb) will increase coverage by 0%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           version/v3.0   #228   +/-   ##
===========================================
  Coverage            95%    95%           
===========================================
  Files                56     56           
  Lines              2349   2350    +1     
===========================================
+ Hits               2240   2241    +1     
  Misses              109    109           
Impacted Files Coverage Δ
src/SmartFormat/Core/Output/NullOutput.cs 100% <ø> (ø)
src/SmartFormat/Core/Output/StringOutput.cs 81% <ø> (ø)
src/SmartFormat/Core/Output/TextWriterOutput.cs 100% <ø> (ø)
src/SmartFormat/Core/Output/ZStringOutput.cs 96% <67%> (ø)
src/SmartFormat/Utilities/ZStringExtensions.cs 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed6c5eb...212eac2. Read the comment docs.

@axunonb axunonb merged commit 2e9dbb2 into axuno:version/v3.0 Nov 17, 2021
@axunonb axunonb deleted the pr-remove-CysharpText-references branch November 17, 2021 20:09
axunonb added a commit that referenced this pull request Nov 17, 2021
Updates for [#228](#228)
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Mar 10, 2022
Breaking change to version/3.0-alpha.4
* Created ZStringBuilder as a wrapper around Utf16ValueStringBuilder
* Replaced occurrences of Utf16ValueStringBuilder with ZStringBuilder.
* Affects IOutput, NullOutput, StringOutput, TextWriterOoutput, ZStringOutput
axunonb added a commit to axunonb/SmartFormat that referenced this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant