Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverflowException: Value was either too large or too small for an unsigned byte. #211

Closed
bogatykh opened this issue Oct 20, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@bogatykh
Copy link

SmartFormat 2.7.0

Framework: .NET Core 3.1

Steps to reproduce:

`

        string template = "Value: **{VĀLUĒ}**";

        Dictionary<string, object> a = new Dictionary<string, object>();

        var smartFormatter = Smart.CreateDefaultSmartFormat();

        var res = smartFormatter.Format(template, a);

`

Exception:
at System.Convert.ThrowByteOverflowException()
at SmartFormat.Core.Parsing.Parser.ParseFormat(String format, String[] formatterExtensionNames)
at SmartFormat.SmartFormatter.Format(IFormatProvider provider, String format, Object[] args)
at SmartFormat.SmartFormatter.Format(String format, Object[] args)

Code above works in 2.6.2 version of SmartFormat reporting "Invalid character in the selector, Invalid character in the selector".

@axunonb axunonb self-assigned this Oct 20, 2021
@axunonb axunonb added this to the version/v3 milestone Oct 20, 2021
@axunonb axunonb added the Bug label Oct 20, 2021
@axunonb
Copy link
Member

axunonb commented Oct 20, 2021

Thanks. In an effort to show the failing character, unicode was not reflected:

$"'0x{Convert.ToByte(inputChar):X}': "
throws for unicode - is used twice in the project

must be changed to
$"'0x{Convert.ToUInt32(inputChar).ToString("x")}': "
result: '0x100'

axunonb added a commit to axunonb/SmartFormat that referenced this issue Oct 20, 2021
Illegal characters that are not 8-bit, will not throw unexpected ThrowByteOverflowException
@axunonb axunonb closed this as completed Oct 20, 2021
axunonb added a commit to axunonb/SmartFormat that referenced this issue Oct 21, 2021
Backported bug fixes from v3.0.0-alpha:
axuno#179 - Corrected DualFromZeroToTwo plural rule
axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException
axunonb added a commit to axunonb/SmartFormat that referenced this issue Oct 21, 2021
axuno#179 - Corrected DualFromZeroToTwo plural rule
axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException
axunonb added a commit that referenced this issue Oct 21, 2021
Bumped version to 2.7.1

Back-ported bug fixes from v3.0.0-alpha:
#179 - Corrected DualFromZeroToTwo plural rule
#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException
axunonb added a commit to axunonb/SmartFormat that referenced this issue Oct 21, 2021
commit ebb820c
Merge: 365bbd0 ca28b30
Author: axunonb <[email protected]>
Date:   Thu Oct 21 10:06:49 2021 +0200

    Merge branch 'axuno:main' into main

commit ca28b30
Author: axunonb <[email protected]>
Date:   Thu Oct 21 10:05:03 2021 +0200

    Backport fixes from v3 (axuno#213)

    Bumped version to 2.7.1

    Back-ported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 365bbd0
Author: axunonb <[email protected]>
Date:   Thu Oct 21 09:16:12 2021 +0200

    Bumped version to 2.7.1

    Backported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 3165fc7
Author: axunonb <[email protected]>
Date:   Thu Oct 21 08:03:32 2021 +0200

    Updated NuGet secure key

commit 8169585
Author: axunonb <[email protected]>
Date:   Sun Sep 5 23:09:38 2021 +0200

    Update README.md

commit 1e09b6a
Author: axunonb <[email protected]>
Date:   Mon Aug 30 01:52:50 2021 +0200

    Update README.md

commit 8954f3e
Author: axunonb <[email protected]>
Date:   Mon Aug 30 01:51:32 2021 +0200

    Update README.md

commit a16b01c
Author: axunonb <[email protected]>
Date:   Tue Jun 15 00:06:03 2021 +0200

    Update README.md

commit d9462f5
Author: axunonb <[email protected]>
Date:   Tue Jun 15 00:05:17 2021 +0200

    Update README.md
axunonb added a commit to axunonb/SmartFormat that referenced this issue Nov 2, 2021
commit a8dec64
Merge: ebb820c c4f0115
Author: axunonb <[email protected]>
Date:   Tue Nov 2 21:55:35 2021 +0100

    Merge branch 'axuno:main' into main

commit c4f0115
Author: axunonb <[email protected]>
Date:   Tue Nov 2 21:54:46 2021 +0100

    Delete .github/workflows directory

commit 3283ba9
Author: axunonb <[email protected]>
Date:   Tue Nov 2 17:05:09 2021 +0100

    Remove demo projects

commit 0ebf3f4
Author: axunonb <[email protected]>
Date:   Tue Nov 2 16:30:42 2021 +0100

    Corrected path to test project

commit a9a79d1
Author: axunonb <[email protected]>
Date:   Tue Nov 2 16:22:48 2021 +0100

    Add AltCover to test

commit 608533f
Author: axunonb <[email protected]>
Date:   Tue Nov 2 16:07:01 2021 +0100

    Update build.yml

commit 3005692
Author: axunonb <[email protected]>
Date:   Tue Nov 2 15:00:06 2021 +0100

    Update build.yml

commit 4683d59
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:23:29 2021 +0100

    Update build.yml

commit d3f9b68
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:19:05 2021 +0100

    Update build.yml

commit 4ac19ea
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:11:42 2021 +0100

    Update build.yml

commit ef76dba
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:08:13 2021 +0100

    Update build.yml

commit e2406b4
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:01:07 2021 +0100

    Update build.yml

commit adee45a
Author: axunonb <[email protected]>
Date:   Tue Nov 2 14:00:40 2021 +0100

    Update build.yml

commit 5464bb9
Author: axunonb <[email protected]>
Date:   Tue Nov 2 13:53:50 2021 +0100

    Create build.yml

commit ebb820c
Merge: 365bbd0 ca28b30
Author: axunonb <[email protected]>
Date:   Thu Oct 21 10:06:49 2021 +0200

    Merge branch 'axuno:main' into main

commit ca28b30
Author: axunonb <[email protected]>
Date:   Thu Oct 21 10:05:03 2021 +0200

    Backport fixes from v3 (axuno#213)

    Bumped version to 2.7.1

    Back-ported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 365bbd0
Author: axunonb <[email protected]>
Date:   Thu Oct 21 09:16:12 2021 +0200

    Bumped version to 2.7.1

    Backported bug fixes from v3.0.0-alpha:
    axuno#179 - Corrected DualFromZeroToTwo plural rule
    axuno#211 . Illegal placeholder characters that are not 8-bit, will no more throw unexpected ThrowByteOverflowException

commit 3165fc7
Author: axunonb <[email protected]>
Date:   Thu Oct 21 08:03:32 2021 +0200

    Updated NuGet secure key

commit 8169585
Author: axunonb <[email protected]>
Date:   Sun Sep 5 23:09:38 2021 +0200

    Update README.md

commit 1e09b6a
Author: axunonb <[email protected]>
Date:   Mon Aug 30 01:52:50 2021 +0200

    Update README.md

commit 8954f3e
Author: axunonb <[email protected]>
Date:   Mon Aug 30 01:51:32 2021 +0200

    Update README.md

commit a16b01c
Author: axunonb <[email protected]>
Date:   Tue Jun 15 00:06:03 2021 +0200

    Update README.md

commit d9462f5
Author: axunonb <[email protected]>
Date:   Tue Jun 15 00:05:17 2021 +0200

    Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants