Fix: Parser wont throw on illegal selector chars #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now targeting frameworks netstandard2.0, netstandard2.1, net461
Codecov Report
@@ Coverage Diff @@
## version/v3.0 #212 +/- ##
============================================
Coverage 17% 17%
============================================
Files 99 99
Lines 12916 12916
============================================
Hits 2233 2233
Misses 10683 10683
Continue to review full report at Codecov.
|
axunonb
added a commit
that referenced
this pull request
Oct 20, 2021
axunonb
added a commit
to axunonb/SmartFormat
that referenced
this pull request
Mar 10, 2022
Illegal placeholder characters that are not 8-bit, will not throw unexpected ThrowByteOverflowException
axunonb
added a commit
to axunonb/SmartFormat
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
An unexpected
ThrowByteOverflowExceptionwas thrown, if the illegal character was not 8-bit.This is resolved.