-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Unicode escape support #166
Merged
axunonb
merged 26 commits into
axuno:version/v3.0
from
karljj1:feature/unicode-escape-support
May 27, 2021
Merged
Changes from 5 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a52d832
Merge pull request #1 from axuno/master
karljj1 bf2379c
Merge remote-tracking branch 'Original/main'
karljj1 afd5b77
Update issue templates
axunonb 1d22508
Inserted a link to merged version/v3 changes
axunonb 11c3033
Updated README
axunonb d1779f9
Merge remote-tracking branch 'upstream/main' into version/v3.0
axunonb cb5559a
Make parser fully covered with unit tests
axunonb e327de5
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb cab97df
Updated CHANGES.md
axunonb e8d9c93
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb 294f810
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb 792c391
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb 4f45a84
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb e49db1e
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb 2c562b5
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb 2ba8c5f
Updated .editorconfig
axunonb 46f02d4
Added support for Unicode Escape sequences
karljj1 f358b60
Updated test with unicode escape sequence support and fixed some typos
karljj1 a525889
Fixed typo
karljj1 933e992
Some additional tests to keep code coverage happy
karljj1 7c3a12e
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb bda63e0
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb ef58744
Merge remote-tracking branch 'upstream/version/v3.0' into version/v3.0
axunonb 503e0a5
Some additional tests to keep code coverage happy
karljj1 0477b1e
Rebased to version/v3.0
axunonb 06c47eb
Rebased to version/v3.0
axunonb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be safe to do
i += 6 and break here to save having to iterate over the numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safe enough. It's the same as with other escaped characters. Illegal escape sequences throw when trying to unescape the literal by the formatter. I don't see an advantage already throwing in the parser.