Feature/Unicode escape support #166
Conversation
Update to latest changes
|
|
||
| // Is this a unicode escape sequence? | ||
| if (i + 1 < format.Length && format[i + 1] == 'u') | ||
| lastI = i + 6; // \u0000 format |
There was a problem hiding this comment.
Do you think it would be safe to do
i += 6 and break here to save having to iterate over the numbers?
There was a problem hiding this comment.
Safe enough. It's the same as with other escaped characters. Illegal escape sequences throw when trying to unescape the literal by the formatter. I don't see an advantage already throwing in the parser.
Codecov Report
@@ Coverage Diff @@
## version/v3.0 #166 +/- ##
===========================================
Coverage 94% 95%
===========================================
Files 42 42
Lines 1826 1839 +13
===========================================
+ Hits 1725 1738 +13
Misses 101 101
Continue to review full report at Codecov.
|
|
Very nice, thanks! Should definitely become part of SF. |
* Added support for Unicode Escape sequences * Updated test with unicode escape sequence support and fixed some typos * Fixed typo * Some additional tests to keep code coverage happy * Rebased to version/v3.0
We often want to write Unicode escape characters in our text e.g
\u2022will become •.This adds support to the Parser and LiteralText to handle Unicode in the form
\uXXXXI also fixed some typos in the surrounding code.