Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: specify commits of tests #1536

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Nov 9, 2023

What this PR does / why we need it?

This PR specifies commits of tests.

So, we could find a corresponding version of tests for every historical commits of Axon.
And, the CI won't be broken when those tests have new commits.

Temporarily fix the CI to allow PRs merged before #1534 fixed.

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape

This comment was marked as off-topic.

Copy link

github-actions bot commented Nov 9, 2023

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review November 9, 2023 05:46
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner November 9, 2023 05:46
@Flouse Flouse added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit fdb80b6 Nov 9, 2023
29 checks passed
@yangby-cryptape yangby-cryptape deleted the yangby/chore/specify-commits-of-tests branch November 9, 2023 07:41
@yangby-cryptape
Copy link
Collaborator Author

yangby-cryptape commented Nov 9, 2023

@Flouse Please add those optional checks to the required checks when merges a PR.
Any PR should fix all tests by themselves, so later PRs won't be blocked.

For example, #1532 was merged without following checks:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

@Flouse
Copy link
Contributor

Flouse commented Nov 9, 2023

@Flouse Please add those optional checks to the required checks when merges a PR. Any PR should fix all tests by themselves, so later PRs won't be blocked.

For example, #1532 was merged without following checks:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

done.
image

KaoImin pushed a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants