Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no-std version of axon-tools #1532

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

wenyuanhust
Copy link
Contributor

@wenyuanhust wenyuanhust commented Nov 7, 2023

What this PR does / why we need it?

This PR add no-std version of axon-tools to support forcerelay related contracts.

What is the impact of this PR?

No Breaking Change

PR relation:

  • Ref #
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@wenyuanhust wenyuanhust marked this pull request as ready for review November 7, 2023 08:38
@wenyuanhust wenyuanhust requested a review from a team as a code owner November 7, 2023 08:38
@KaoImin KaoImin changed the title feature: add no-std version of axon-tools feat: add no-std version of axon-tools Nov 7, 2023
@wenyuanhust wenyuanhust force-pushed the opt branch 2 times, most recently from e10aabb to c8e09c2 Compare November 8, 2023 02:17
Copy link
Contributor

@ashuralyk ashuralyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a test case that takes a no-std version of axon-tools to verify an Axon block?

@wenyuanhust wenyuanhust added this pull request to the merge queue Nov 8, 2023
@wenyuanhust
Copy link
Contributor Author

is it possible to add a test case that takes a no-std version of axon-tools to verify an Axon block?

API verify_proof is shared by std and no-std version, so the test case for std will test that of no-std too.
The only difference is under std, the mock data can be deserialzed easier.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2023
@wenyuanhust wenyuanhust added this pull request to the merge queue Nov 8, 2023
Merged via the queue into axonweb3:main with commit 37cddb7 Nov 8, 2023
12 checks passed
@yangby-cryptape

This comment was marked as off-topic.

Copy link

github-actions bot commented Nov 8, 2023

CI tests run on commit:

CI test list:

  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@yangby-cryptape yangby-cryptape mentioned this pull request Nov 9, 2023
6 tasks
KaoImin pushed a commit that referenced this pull request Nov 17, 2023
* refactor: impl-serde & proof shouldn't be default features

* feat: add no-std version of axon-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants