Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hardfork proposal feature #1404

Merged
merged 2 commits into from
Sep 11, 2023
Merged

feat: hardfork proposal feature #1404

merged 2 commits into from
Sep 11, 2023

Conversation

driftluo
Copy link
Contributor

@driftluo driftluo commented Sep 5, 2023 •
edited by KaoImin
Loading

What this PR does / why we need it?

This PR provides the full process of hardfork, but does not include the initialization process from the user command line parameters

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@driftluo driftluo requested a review from a team as a code owner September 5, 2023 06:16
@driftluo driftluo requested review from blckngm, wenyuanhust and KaoImin and removed request for blckngm and wenyuanhust September 5, 2023 06:16
@driftluo driftluo force-pushed the hardfork-proposal-feature branch 4 times, most recently from 86a3ee7 to 5ea80d6 Compare September 5, 2023 09:50
@driftluo driftluo force-pushed the hardfork-proposal-feature branch 2 times, most recently from 74ba56c to a4f1b71 Compare September 6, 2023 03:47
@Flouse Flouse requested a review from a team September 7, 2023 03:58
KaoImin
KaoImin reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@KaoImin KaoImin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this PR include parsing the hardfork arguments from command line?

@driftluo
Copy link
Contributor Author

driftluo commented Sep 7, 2023

Doesn't this PR include parsing the hardfork arguments from command line?

wait until Boyu's command line reconstruction is completed before submitting it.

@driftluo driftluo force-pushed the hardfork-proposal-feature branch from a4f1b71 to fddd7c8 Compare September 7, 2023 04:55
@Flouse Flouse marked this pull request as draft September 7, 2023 14:13
@Flouse
Copy link
Contributor

Flouse commented Sep 7, 2023 •
edited
Loading

Unit Test

No space left on device - https://github.com/axonweb3/axon/actions/runs/6105563759/job/16569277591#step:5:1566

=> Clean the cache and rerun -> https://github.com/axonweb3/axon/actions/runs/6105563759 ✅

@driftluo driftluo force-pushed the hardfork-proposal-feature branch 2 times, most recently from f735910 to 592e7ca Compare September 8, 2023 08:40
@driftluo driftluo marked this pull request as ready for review September 8, 2023 09:27
KaoImin
KaoImin previously approved these changes Sep 11, 2023
View reviewed changes
@KaoImin

This comment was marked as off-topic.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
@KaoImin KaoImin enabled auto-merge September 11, 2023 02:23
@KaoImin KaoImin removed the request for review from wenyuanhust September 11, 2023 02:54
@KaoImin
Copy link
Contributor

KaoImin commented Sep 11, 2023 •
edited
Loading

Doesn't this PR include parsing the hardfork arguments from command line?

wait until Boyu's command line reconstruction is completed before submitting it.

@driftluo #1402 has merged

@driftluo driftluo force-pushed the hardfork-proposal-feature branch from 592e7ca to 702e7dd Compare September 11, 2023 07:07
@KaoImin
Copy link
Contributor

KaoImin commented Sep 11, 2023

/run-ci

@github-actions

This comment was marked as outdated.

Sign in to view
@KaoImin KaoImin added this pull request to the merge queue Sep 11, 2023
@KaoImin KaoImin removed this pull request from the merge queue due to a manual request Sep 11, 2023
@github-actions
Copy link

CI tests run on commit:

CI test list:

  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin
Copy link
Contributor

KaoImin commented Sep 11, 2023

/run-ci

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • Web3 Compatible Tests

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 11, 2023
@yangby-cryptape
Copy link
Collaborator

Failed status duet to a nondeterministic failure, I have met it many times in my local development environment.

@yangby-cryptape yangby-cryptape added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit dd745ad Sep 11, 2023
20 checks passed
@driftluo driftluo deleted the hardfork-proposal-feature branch September 11, 2023 09:03
@Flouse Flouse mentioned this pull request Sep 12, 2023
Merged
7 tasks
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@KaoImin KaoImin KaoImin approved these changes

Assignees

@driftluo driftluo

Labels
t:feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driftluo @Flouse @KaoImin @yangby-cryptape