Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): integrate genesis-generator into axon init #1402

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Sep 5, 2023

What this PR does / why we need it?

Currently, genesis-generator has too many hardcode variables,

What is the impact of this PR?

BREAKING CHANGE:

  • Command line interface

    The sub-command axon run requires a new argument --key $KEY_HEX_STR_WITH_0X_PREFIX or --key-file $KEY_IN_BINARY_FILE, to provided the private key of genesis transactions.

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape yangby-cryptape requested a review from a team as a code owner September 5, 2023 02:53
@Flouse Flouse marked this pull request as draft September 5, 2023 02:55
@yangby-cryptape yangby-cryptape force-pushed the yangby/feature/integrate-genesis-generator branch 2 times, most recently from 350431b to 88a29b9 Compare September 6, 2023 02:43
@yangby-cryptape yangby-cryptape changed the title [Blocked By #1386] feat(cli): integrate genesis-generator into axon init feat(cli): integrate genesis-generator into axon init Sep 6, 2023
@yangby-cryptape yangby-cryptape marked this pull request as ready for review September 6, 2023 02:47
@yangby-cryptape yangby-cryptape force-pushed the yangby/feature/integrate-genesis-generator branch from 88a29b9 to 88b269b Compare September 6, 2023 06:53
@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@yangby-cryptape yangby-cryptape force-pushed the yangby/feature/integrate-genesis-generator branch from 88b269b to daac1bf Compare September 6, 2023 12:32
@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@yangby-cryptape

This comment was marked as outdated.

KaoImin
KaoImin previously approved these changes Sep 7, 2023
@Flouse Flouse requested review from a team, jjyr, blckngm and driftluo and removed request for a team, jjyr and blckngm September 7, 2023 03:58
README.md Outdated Show resolved Hide resolved
@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

CI tests run on commit:

CI test list:

Please check ci test results later.

@KaoImin KaoImin added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit cc2a393 Sep 11, 2023
20 checks passed
@KaoImin KaoImin mentioned this pull request Sep 11, 2023
7 tasks
@yangby-cryptape yangby-cryptape deleted the yangby/feature/integrate-genesis-generator branch September 11, 2023 09:58
@Flouse Flouse linked an issue Sep 26, 2023 that may be closed by this pull request
20 tasks
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate genesis-generator into axon. Transactions root of genesis block is incorrect
3 participants