-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): integrate genesis-generator
into axon init
#1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
force-pushed
the
yangby/feature/integrate-genesis-generator
branch
2 times, most recently
from
September 6, 2023 02:43
350431b
to
88a29b9
Compare
yangby-cryptape
changed the title
[Blocked By #1386] feat(cli): integrate
feat(cli): integrate Sep 6, 2023
genesis-generator
into axon init
genesis-generator
into axon init
yangby-cryptape
force-pushed
the
yangby/feature/integrate-genesis-generator
branch
from
September 6, 2023 06:53
88a29b9
to
88b269b
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
yangby-cryptape
force-pushed
the
yangby/feature/integrate-genesis-generator
branch
from
September 6, 2023 12:32
88b269b
to
daac1bf
Compare
KaoImin
reviewed
Sep 6, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
KaoImin
previously approved these changes
Sep 7, 2023
Flouse
reviewed
Sep 7, 2023
yangby-cryptape
force-pushed
the
yangby/feature/integrate-genesis-generator
branch
from
September 7, 2023 04:53
42e33c0
to
ea3eee7
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
Flouse
approved these changes
Sep 7, 2023
KaoImin
approved these changes
Sep 11, 2023
7 tasks
yangby-cryptape
deleted the
yangby/feature/integrate-genesis-generator
branch
September 11, 2023 09:58
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
genesis-generator
intoaxon
. #1346.=> All configurations could be readable.
Currently,
genesis-generator
has too many hardcode variables,axon/devtools/genesis-generator/src/main.rs
Line 26 in 8815f58
axon/devtools/genesis-generator/src/main.rs
Lines 67 to 69 in 8815f58
axon/devtools/genesis-generator/src/main.rs
Line 115 in 8815f58
and requires all private keys of all nodes.
axon/devtools/genesis-generator/src/main.rs
Lines 97 to 102 in 8815f58
axon/devtools/genesis-generator/src/main.rs
Lines 124 to 129 in 8815f58
What is the impact of this PR?
BREAKING CHANGE:
Command line interface
The sub-command
axon run
requires a new argument--key $KEY_HEX_STR_WITH_0X_PREFIX
or--key-file $KEY_IN_BINARY_FILE
, to provided the private key of genesis transactions.CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc