-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): split sub-command run
to init
and run
#1386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
force-pushed
the
yangby/refactor-core-run
branch
from
August 31, 2023 08:30
62d01e3
to
68e2b0e
Compare
yangby-cryptape
force-pushed
the
yangby/feature/split-run-command
branch
6 times, most recently
from
September 4, 2023 06:38
6f5e38f
to
024cd74
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
The CI could not be passed, since the dispatched actions will always use the workflow files in main branch. I tested the failed CI check in my own forked repo and it was passed. I updated the CI status of "Web3 Compatible Tests" manually to "Tested in my forked repo". |
Flouse
requested review from
driftluo and
KaoImin
and removed request for
wenyuanhust and
Simon-Tl
September 4, 2023 06:59
yangby-cryptape
force-pushed
the
yangby/feature/split-run-command
branch
from
September 4, 2023 16:50
024cd74
to
116130f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
7 tasks
yangby-cryptape
force-pushed
the
yangby/feature/split-run-command
branch
from
September 5, 2023 03:20
116130f
to
b89083f
Compare
Flouse
approved these changes
Sep 5, 2023
This was referenced Sep 5, 2023
KaoImin
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR resolves #1345.
What is the impact of this PR?
Breaking Change
Command line interface
axon run
, users have to initialize the chain data withaxon init
.CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci
.CI Switch
CI Description
cargo clippy --all --all-targets --all-features
cargo +nightly fmt --all -- --check
andcargo sort -gwc