Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): split sub-command run to init and run #1386

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Aug 29, 2023

What this PR does / why we need it?

This PR resolves #1345.

What is the impact of this PR?

Breaking Change

  • Command line interface

    • Before execute axon run, users have to initialize the chain data with axon init.
CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape yangby-cryptape force-pushed the yangby/refactor-core-run branch from 62d01e3 to 68e2b0e Compare August 31, 2023 08:30
@yangby-cryptape yangby-cryptape changed the base branch from yangby/refactor-core-run to main August 31, 2023 08:53
@yangby-cryptape yangby-cryptape force-pushed the yangby/feature/split-run-command branch 6 times, most recently from 6f5e38f to 024cd74 Compare September 4, 2023 06:38
@yangby-cryptape

This comment was marked as off-topic.

@github-actions

This comment was marked as outdated.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review September 4, 2023 06:55
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner September 4, 2023 06:55
@yangby-cryptape
Copy link
Collaborator Author

yangby-cryptape commented Sep 4, 2023

The CI could not be passed, since the dispatched actions will always use the workflow files in main branch.

I tested the failed CI check in my own forked repo and it was passed.

I updated the CI status of "Web3 Compatible Tests" manually to "Tested in my forked repo".

@Flouse Flouse requested review from driftluo and KaoImin and removed request for wenyuanhust and Simon-Tl September 4, 2023 06:59
@yangby-cryptape yangby-cryptape force-pushed the yangby/feature/split-run-command branch from 024cd74 to 116130f Compare September 4, 2023 16:50
@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

CI tests run on commit:

CI test list:

  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

Please check ci test results later.

@yangby-cryptape yangby-cryptape force-pushed the yangby/feature/split-run-command branch from 116130f to b89083f Compare September 5, 2023 03:20
@KaoImin KaoImin added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 85ab2d3 Sep 5, 2023
26 checks passed
@yangby-cryptape yangby-cryptape deleted the yangby/feature/split-run-command branch September 6, 2023 02:14
@Flouse Flouse added t:feature and removed feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split sub-command run to init and run
3 participants