Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipts should support EIP-2718 since Tansactions already support EIP-2930 and EIP-1559 #1260

Closed
yangby-cryptape opened this issue Jul 2, 2023 · 2 comments · Fixed by #1270
Assignees

Comments

@yangby-cryptape
Copy link
Collaborator

Contact Details

No response

Propose-a-new-feature

Summary

In EIPs, it said:

Axon transactions support EIP-2930 and EIP-1559:

pub enum UnsignedTransaction {
Legacy(LegacyTransaction),
Eip2930(Eip2930Transaction),
Eip1559(Eip1559Transaction),
}

But Axon receipts not support EIP-2718.

Details

According to EIP-2718:

Receipt is either TransactionType || ReceiptPayload or LegacyReceipt.
... ...
LegacyReceipt is kept to be RLP encoded bytes; it is rlp([status, cumulativeGasUsed, logsBloom, logs]).
... ...
ReceiptPayload is an opaque byte array whose interpretation is dependent on the TransactionType and defined in future EIPs.

As EIP-2930 defined: if TransactionType is 1, ReceiptPayload is rlp([status, cumulativeGasUsed, logsBloom, logs]).

As EIP-1559 defined: if TransactionType is 2, ReceiptPayload is rlp([status, cumulative_transaction_gas_used, logs_bloom, logs]).

Alternatives you've considered

No response

Anything else?

It's almost impossible to verify a Axon receipt with receipts root:

@github-actions

This comment was marked as duplicate.

1 similar comment
@github-actions

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants