The implemention of receipts root in block is incorrect

[yangby-cryptape]

Contact Details

No response

Current Behavior

Summary

If "Axon is compatible with Ethereum" as that written in the README.md, the implementation of receipts root in block is incorrect.

Details

• The Block::receipts_root is set from ExecResp.receipt_root.

  axon/protocol/src/types/block.rs

  Line 118 in c7a471b

  receipts_root: exec_resp.receipt_root,

• The ExecResp.receipt_root is merkle root of a list of hashes.

  axon/core/executor/src/lib.rs

  Lines 175 to 182 in c7a471b

  	ExecResp {
  	state_root: new_state_root,
  	receipt_root: TrieMerkle::from_iter(hashes.iter().enumerate())
  	.root_hash()
  	.unwrap_or_default(),
  	gas_used: gas,
  	tx_resp: res,
  	}

• Each hash in hashes is AxonExecutor::evm_exec(...).ret.

  axon/core/executor/src/lib.rs

  Lines 142 to 149 in c7a471b

  	let mut r = system_contract_dispatch(adapter, tx)
  	.unwrap_or_else(|| Self::evm_exec(adapter, &config, &precompiles, tx));
  	r.logs = adapter.get_logs();
  	gas += r.gas_used;
  	fee = fee.checked_add(r.fee_cost).unwrap_or(U256::max_value());
  	hashes.push(Hasher::digest(&r.ret));

• TxResp.ret is set from res.

  axon/core/executor/src/lib.rs

  Lines 282 to 284 in c7a471b

  	TxResp {
  	exit_reason: exit,
  	ret: res,

• The res is transact_call(...).1

  axon/core/executor/src/lib.rs

  Lines 232 to 248 in c7a471b

  	let (exit, res) = match tx.transaction.unsigned.action() {
  	TransactionAction::Call(addr) => executor.transact_call(
  	tx.sender,
  	*addr,
  	*tx.transaction.unsigned.value(),
  	tx.transaction.unsigned.data().to_vec(),
  	gas_limit.as_u64(),
  	access_list,
  	),
  	TransactionAction::Create => executor.transact_create(
  	tx.sender,
  	*tx.transaction.unsigned.value(),
  	tx.transaction.unsigned.data().to_vec(),
  	gas_limit.as_u64(),
  	access_list,
  	),
  	};

• So, the res is just Vec<u8> which represents the return data of the called contract, it is NOT the receipt of transaction.

Expected Behavior

None.

OS

Not Associated

Axon version

No response

Kernel

Not Associated

Relevant log output

No response

Anything else?

p.s. I don't like your issue template, at least it's not suitable for this issue.